Add total stack usage to memory matrix. #223
Conversation
mbed_greentea/mbed_report_api.py
Outdated
| @@ -768,6 +770,10 @@ def exporter_memory_metrics_csv(test_result_ext, test_suite_properties=None): | |||
| for test_suite_name in test_results: | |||
| test = test_results[test_suite_name] | |||
|
|
|||
| # If test didn't pass, memory stats doesn't make much sense | |||
| if test['single_test_result'] != TEST_RESULT_OK: | |||
| continue | |||
There was a problem hiding this comment.
@studavekar Seems like this is pretty harmless to leave in anyway right? Maybe the test failed due to a stack overflow...
There was a problem hiding this comment.
Yeah true that is good candidate where if test fails we would want the results of stack. However for failing tests the memory data can't be truly trusted. If test fails at init_xxx() the data reported by it would smaller. So for reporting we are ignoring the fail tests.
Can take out this check so we get data in either case.
studavekar
force-pushed
the
stack_usage_total
branch
2 times, most recently
from
a4c3532 to
43854de
Compare
mbed_greentea/mbed_report_api.py
Outdated
| @@ -17,6 +17,8 @@ | |||
| Author: Przemyslaw Wirkus <[email protected]> | |||
| """ | |||
|
|
|||
| from mbed_test_api import TEST_RESULT_OK | |||
There was a problem hiding this comment.
One last nit pick! This line isn't necessary any more since you removed that last check. Mind pulling this out too?
studavekar
force-pushed
the
stack_usage_total
branch
2 times, most recently
from
6523b8f to
29a1cdc
Compare
This change adds total stack usage which is sum of max stack used by each thread.
studavekar
force-pushed
the
stack_usage_total
branch
from
29a1cdc to
bb04c24
Compare
| for cur_thread_stack_info in thread_stack_info: | ||
| if cur_thread_stack_info['stack_size'] > max_thread_stack_size: | ||
| max_thread_stack_size = cur_thread_stack_info['stack_size'] | ||
| max_thread = cur_thread_stack_info | ||
|
|
||
| max_stack_usage_total += cur_thread_stack_info['max_stack'] |
There was a problem hiding this comment.
updated it to correctly report max_stage_usage_total
This change adds total stack usage which is sum of max stack used by each
thread.