Add support for the VBLUno51 board #290

iotmember · 2017-07-21T16:04:18Z

Add support for the VBLUno51 board

Email from Sarah Marsh (mbed):

Hi,

Here is your daplink board ID: C006
The slug: VBLUNO51

When I execute mbedls, it looks like you have used the DAPLink ID for the NRF51_DK. You need your own unique ID. We are running the tests with the NRF51_DK ID mocked as your platform, but you will need to do the following to be mbed enabled:

Please submit a PR against mbed-ls (https://github.com/ARMmbed/mbed-ls), so your board can be detected with our tools.

Please also submit a PR against DAPLink (https://github.com/mbedmicro/DAPLink), so that your board is uniquely identifiable.

Thanks,
Sarah

The VBLUno51 board was added to mbed-os 5.5.2 released
ARMmbed/mbed-os#4629
ARMmbed/mbed-os#4719

Signed-off-by: iotvietmember [email protected]

iotmember · 2017-07-21T16:05:49Z

@c1728p9 @maclobdell I hope that this commit will be reviewed soon. Thank you very much

c1728p9

Hi @iotvietmember, thanks for the PR. Before I can merge this you'll need to sign the contributor's agreement if you haven't already:
https://developer.mbed.org/contributor_agreement/

If you have, just let me know what mbed account you used.

c1728p9 · 2017-07-22T04:02:17Z

source/daplink/usb2uart/usbd_user_cdc_acm.c

    UART_Config.FlowControl = UART_FLOW_CONTROL_NONE;
+#endif    


Please make this a runtime setting rather than a define

@c1728p9 I used the "BOARD_VBLUNO51" macro in "records/board/vbluno51.yaml" file

Flow control could be useful to other devices as well. Could you add a function to enable it like the sam3u2c has:
https://github.com/mbedmicro/DAPLink/blob/master/source/hic_hal/atmel/sam3u2c/uart.c#L397

Then you can use prerun_board_config() to enable it:
https://github.com/mbedmicro/DAPLink/blob/master/source/board/ncs36510rf.c#L21

@c1728p9 The VBLUno51, VBLUno52 boards always use UART Hardware flow control (RTS/CTS) feature for DAPLink interface

I understand, but as more and more boards use flow control this code will get bigger and bigger

#if defined(BOARD_VBLUNO51) || defined(BOARD_VBLUNO52) || ... || defined(BoardN)

If this is a runtime changeable option and is set in board specific code the all boards can use the same code without defines.

c1728p9 · 2017-07-22T04:03:43Z

source/board/override_vbluno51/IO_Config_Override.h

+#define FUNC_1                          1
+#define PULL_DOWN_ENABLED               (1 << 3)
+#define PULL_UP_ENABLED                 (2 << 3)
+#define OPENDRAIN                       (1 << 10)


Are you unable to use the standard pinout for your board? If not, can you document in this file which pins differ?

The VBLUno51 board has not used standard pinout. The following file is VBLUno51's schematic
schematic

In the VBLUn51 board, TGT_SWCLK is PIO0_9(18). While standard design used PIO0_7(16) for TGT_SWCLK
Thanks

Could you add this as a comment to this file?

I have just added comment to this file

iotmember · 2017-07-22T05:09:47Z

@c1728p9 Beside that, I signed the contributor's agreement with vbluno_support account

iotmember · 2017-07-24T16:53:09Z

@c1728p9 Could you please review this commit. Thanks

iotmember · 2017-07-25T12:30:32Z

@c1728p9 Hope that this commit would be reviewed soon.

c1728p9

Thanks for the updates @iotvietmember. This PR has conflicts with master so it needs to be rebased before I and test and merged it.

Also, I added a few more comments to the PR, none of them preventing it from getting merged though.

c1728p9 · 2017-07-28T14:45:29Z

source/board/vbluno51.c

+void prerun_board_config()
+{
+    uart_enable_flow_control(true);
+}


nitpick - no newline at end of file

Hi @c1728p9 I have added new line at end of this file

c1728p9 · 2017-07-28T14:45:46Z

source/hic_hal/nxp/lpc11u35/uart.c

@@ -146,8 +148,8 @@ int32_t uart_set_configuration(UART_Configuration *config)
            parity = 0x00;
            break;
    }
-
-    if (config->FlowControl == UART_FLOW_CONTROL_RTS_CTS) {
+


nitpick - extra whitesspace

iotmember · 2017-07-28T15:04:13Z

@c1728p9 I have just fixed two errors which you wrote

c1728p9 · 2017-07-28T16:27:15Z

Thanks for the update @iotvietmember. Github won't let me merge this until it is rebased - "This branch has conflicts that must be resolved"

iotmember · 2017-07-28T16:56:32Z

@c1728p9 Thanks. Hope it will resolve soon

c1728p9 · 2017-07-28T21:29:36Z

Hi @iotvietmember, you'll need to use git to perform the rebase. If you want help with this let me know.

The VBLUno51 board has BOARD_ID is 0xC006 Signed-off-by: iotvietmember <[email protected]>

iotmember · 2017-07-29T02:43:04Z

Hi @c1728p9 , I have just done the rebase. Could you please review for me. Thank you very much

c1728p9 · 2017-07-29T16:16:25Z

/morph test

studavekar · 2017-07-31T03:18:33Z

/morph test

iotmember · 2017-07-31T07:50:49Z

@c1728p9 thank you very much

iotmember force-pushed the add_target_vbluno51 branch 2 times, most recently from 5c080af to 426474a Compare July 21, 2017 16:30

c1728p9 suggested changes Jul 22, 2017

View reviewed changes

iotmember force-pushed the add_target_vbluno51 branch from 426474a to 7daeee6 Compare July 22, 2017 16:29

iotmember force-pushed the add_target_vbluno51 branch from fc25930 to f64d381 Compare July 28, 2017 14:38

c1728p9 reviewed Jul 28, 2017

View reviewed changes

c1728p9 approved these changes Jul 28, 2017

View reviewed changes

Add support for the VBLUno51 board

6074ea1

The VBLUno51 board has BOARD_ID is 0xC006 Signed-off-by: iotvietmember <[email protected]>

iotmember force-pushed the add_target_vbluno51 branch from 60a843c to 6074ea1 Compare July 29, 2017 02:41

c1728p9 merged commit ebcafb0 into ARMmbed:master Jul 31, 2017

iotmember deleted the add_target_vbluno51 branch October 8, 2017 15:32

Add support for the VBLUno51 board #290

Add support for the VBLUno51 board #290

Uh oh!

Conversation

iotmember commented Jul 21, 2017

Uh oh!

iotmember commented Jul 21, 2017

Uh oh!

c1728p9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iotmember commented Jul 22, 2017

Uh oh!

iotmember commented Jul 24, 2017

Uh oh!

iotmember commented Jul 25, 2017

Uh oh!

c1728p9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iotmember commented Jul 28, 2017

Uh oh!

c1728p9 commented Jul 28, 2017

Uh oh!

iotmember commented Jul 28, 2017

Uh oh!

c1728p9 commented Jul 28, 2017

Uh oh!

iotmember commented Jul 29, 2017

Uh oh!

c1728p9 commented Jul 29, 2017

Uh oh!

studavekar commented Jul 31, 2017

Uh oh!

iotmember commented Jul 31, 2017

Uh oh!

Uh oh!