feat: add url-encode? options to path-params#778
Merged
opqdonut merged 2 commits intometosin:masterfrom Feb 6, 2026
Merged
Conversation
Member
|
The change looks good at the first glance, thanks! I'll reread it and merge later this week. Feel free to ping me if you don't hear from me. |
opqdonut
requested changes
Feb 6, 2026
Member
opqdonut
left a comment
opqdonut
left a comment
There was a problem hiding this comment.
I'd like the code to be a bit less repetitive, see my comments. If I don't get an update from you, I'll do these refactors myself and then merge :)
Thanks again for your contribution!
opqdonut
approved these changes
Feb 6, 2026
Member
opqdonut
left a comment
opqdonut
left a comment
There was a problem hiding this comment.
Thanks for the prompt reply!
opqdonut
added a commit
that referenced
this pull request
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to close #519.
I've implement what was suggested on the issue. I've added
{:url-encode? false}as an options.