Using reverse routing to create URI templates results in URL encoded template parameters

[tobyclemson]

I'm trying to use reitit to create URI templates by replacing a path parameter with a URI template parameter, such as in the following:

(def router
  (reitit/router
    [["/api/orders/:id" :order]]))

(def match
  (reitit/match-by-name router :order {:id "{id}"}))

(reitit/match->path match)
=> "/api/orders/%7Bid%7D"

I expect the result to be "/api/orders/{id}" and this is what is expected by most URI template libraries. Is there any way to configure / disable the URL encoding applied to path parameters so that I can get the result I want? As far as I've seen there isn't.

If there isn't, would you accept a PR to allow disabling the built in URL encoding applied to path parameters?

[ikitommi]

Hi. If you look at the match, it should have the original templated string, recall under :template key.

[tobyclemson]

So then you'd recommend I duplicate the template population outside of reitit? I have cases where some parameters need to be populated and others replaced with URI template parameter placeholders, for example:

(def router
  (reitit/router
    [["/api/orders/:order-id/items/:item-id" :order-item]]))

(def path-params
  {:order-id "123"
   :item-id  "{id}"})

(def match
  (reitit/match-by-name 
     router :order-item path-params))

(reitit/match->path match)
=> "/api/orders/123/items/%7Bid%7D"

It would be great to continue to leverage the reverse routing capabilities of reitit but have more control over whether things get URL encoded or not.

I can see that I could do this myself using the following:

(def template (:template match))

(def route (impl/parse template (reitit/options router)))

(impl/path-for route path-params)
=> "/api/orders/123/items/{id}"

but that requires using the undocumented reitit.impl namespace

[rap1ds]

Related issue: #432

[acobster]

I've come across this too, and am currently resorting to "dash-encoding" the params before calling match-by-name, and then decoding them on the other side. Obviously, this is less than ideal. Agree it would be great if I could do something like:

(match-by-name router :route-name {:slugs "a/b/c"} {:url-encode? false})