Remove need for Arc<Mutex<>> on singletons #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there aren't mutable methods on CoreBPE, you can remove the indirections and locks and just return a static reference.
benbrandt
force-pushed
the
improve-singleton-performance
branch
from
f1f3d7b to
048f3c3
Compare
Contributor
Author
|
Pushed lint fixes |
Contributor
Author
|
@zurawiki really sorry, should actually be fixed now |
zurawiki
approved these changes
May 19, 2025
Owner
|
Thanks for adding this fix @benbrandt. The Arc was a temporary hack to help people get started quickly with the crate. I'm glad to see us streamline this code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there aren't mutable methods on CoreBPE, you can remove the
indirections and locks and just return a static reference.