785 with refactors and extra bugfix #832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the topic list when it is open, else resets topic cache if present. Tests amended.
* Parameters renamed to improve understanding * Test ids added. * Mock side-effect added to improve topic-list present case
Marking a message as edited is independent of handling content or subject updates.
Re-rendering of messages is only applicable if they are indexed, but updating of the topic list is independent of message index status. This commit adjusts the logic to reflect this, ensuring a visible topic list is still updated if related messages have not yet been loaded. Test updated to reflect new behavior (cache invalidation if no topic view) Test added (topic list updated if open, even if message not indexed)
kaustubh-nair
approved these changes
Nov 22, 2020
|
@kaustubh-nair Thanks for the feedback 👍 Merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the trailing commit of #785 with extra refactoring and a bugfix to ensure topic list update is independent of message indexing.
Closes #785
@kaustubh-nair I've not touched your original commit; how does this look?