Use varying symbols for user status. #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves from having a single small bullet to a style similar to the webapp, with circles of varying degrees of fullness: * filled (active) * bottom-filled (idle) * empty (offline) * small (inactive) These are listed most clearly in symbols.py. Tests updated.
neiljp
force-pushed
the
2020-10-29-user-styling
branch
from
f283003 to
803a483
Compare
|
Just pushed an updated version with the unicode in symbols.py. The change is broadly as follows (this is with a search on czo, to show all the statuses):
|
sumanthvrao
reviewed
Nov 3, 2020
| users_btn_list = list() | ||
| for user in users: | ||
| status = user['status'] |
There was a problem hiding this comment.
You seem to have done a small refactor here, but I guess it is small enough to integrate with the other change?
There was a problem hiding this comment.
This is indeed small, and within a function it should be safe enough 👍
|
These symbol changes look nice! 👍 |
|
Thanks for the feedback! 👍 Let's get this merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves from having a single small bullet to a style similar to the
webapp, with circles of varying degrees of fullness:
Tests updated.
NOTE: I'll move the unicode to symbols.py before this is merged.