Adjust subscription op=peer_* events for ZFL35+ #814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neiljp
added
high priority
neiljp
force-pushed
the
2020-10-24-subscription-peer-events-ZFL35
branch
from
1760aab to
6768177
Compare
neiljp
added
the
PR ready to be merged
neiljp
changed the title
neiljp
force-pushed
the
2020-10-24-subscription-peer-events-ZFL35
branch
from
6768177 to
f3e450f
Compare
zulipbot
added
size: XL
neiljp
force-pushed
the
2020-10-24-subscription-peer-events-ZFL35
branch
3 times, most recently
from
6516914 to
650bf57
Compare
neiljp
force-pushed
the
2020-10-24-subscription-peer-events-ZFL35
branch
from
650bf57 to
aa7c147
Compare
Previously these events contained single stream and user ids, but now instead contain lists of each to reduce the numbers of events required for cases where users join or leave large numbers of streams. Note that the server API was changed while the feature level was set to 34, prior to being locked in at ZFL 35, so ZFL 34 can in principle contain both API styles. Consequently tests at ZFL 34 are handled more fully than in other ZFL-dependent cases. Tests added & updated.
neiljp
force-pushed
the
2020-10-24-subscription-peer-events-ZFL35
branch
from
aa7c147 to
f446b69
Compare
|
Merging this now that travis is more reliable again 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously these events contained single stream and user ids, but now instead contain lists of each to reduce the numbers of events required for cases where users join or leave large numbers of streams.
This is already merged into master as of zulip/zulip@7ff3859, so pending zulip/zulip#16628, this should limit breakage for those using czo.