bugfix: Ensure subscription status checked before muting status. #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking the muting status (topics specifically) assumes the stream id is valid, ie. subscribed.
neiljp
force-pushed
the
2020-09-05-bugfix-check-subscribed-before-muting
branch
from
d01eaf9 to
f510541
Compare
neiljp
added
high priority
|
I hit this bug again recently in master, so merging now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes a traceback for me when I do a specific search, since checking muted topic status assumes the stream is subscribed.
The test is updated but is rather implementation-specific.
I'd like to refactor the code further, so this is a bugfix which would benefit from being addressed better in future.