Skip to content

Conversation

preetmishra
Copy link
Member

This introduces an optional argument, --explore/-e, to run the app in an explore mode where messages are not marked as read intentionally.

Tests amended and added.

Fixes #585.

@zulipbot zulipbot added size: M [Automatic label added by zulipbot] enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org labels Aug 25, 2020
@preetmishra preetmishra added the PR needs review PR requires feedback to proceed label Aug 25, 2020
Copy link
Collaborator

@neiljp neiljp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@preetmishra This looks simple but effective 👍

@neiljp neiljp added this to the Next Release milestone Aug 27, 2020
@neiljp neiljp removed the PR needs review PR requires feedback to proceed label Aug 27, 2020
@preetmishra
Copy link
Member Author

@neiljp Thanks! I have updated the name from explore_mode to in_explore_mode.

This introduces an optional argument, --explore/-e, to run the app in an
explore mode where messages are not marked as read intentionally.

A related suggestion note added in the README.

Tests amended and added.

Fixes zulip#585.
@preetmishra preetmishra added the PR needs review PR requires feedback to proceed label Aug 27, 2020
@neiljp
Copy link
Collaborator

neiljp commented Aug 27, 2020

@preetmishra Merging this now 🎉 Thanks for the documentation update too, though I'm considering if later we should make this more prominent.

@neiljp neiljp merged commit e4af01e into zulip:master Aug 27, 2020
@neiljp neiljp removed the PR needs review PR requires feedback to proceed label Aug 27, 2020
@preetmishra preetmishra deleted the feat-explore-mode branch August 30, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request further discussion required Discuss this on #zulip-terminal on chat.zulip.org size: M [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review/Explore/Child mode (don't mark as read)
3 participants