bugfix: helper: Avoid updating unread count for unsubscribed streams. #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: XS
Unread count data from the server may include that for unsubscribed streams, which currently are not stored in Model.stream_dict. In the webapp (zulip/zulip repo), stream data includes unsubscribed and 'never_subscribed' streams (see populate_subscriptions in stream_data.js), so this issue does not arise. This has been an increased or particular issue recently due to addition of support for moving messages between streams. Fixes zulip#694.
neiljp
force-pushed
the
2020-07-bugfix-694
branch
from
911b76a to
3015e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unread count data from the server may include that for unsubscribed streams, which currently are not indexed.
Fixes #694.