core: Avoid writing newline to stdout after UI has loaded. #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: XS
|
I think that line was there so that errors get printed nicely in a new line; but now, they seem to be printing nicely even without that line. LGTM! |
|
@sumanthvrao Good catch! I've a test account that this reliably triggered with, and this definitely seems like it works for that account, as well as being a good fix from a code point of view 👍 The output in case of an error doesn't seem affected either, I agree - thanks for that feedback @amanagr 👍 I'm merging this now; let's see if we observe any more cases of #456. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possibly fixes #456.
@amanagr FYI :)