Clearly indicate nuances in Visual notification settings. #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the label of Visual notifications checkbox to indicate that this setting directly affects other clients, namely Web and desktop.
zee-bit
force-pushed
the
indicate-notification-setting-nuances
branch
from
4b35bc7 to
db6201d
Compare
zee-bit
force-pushed
the
indicate-notification-setting-nuances
branch
from
db6201d to
45aab00
Compare
zulipbot
added
size: M
preetmishra
reviewed
Jul 14, 2021
There was a problem hiding this comment.
@zee-bit Thanks for pushing this promptly. While this is a small addition, I believe it would help improve the user experience significantly. 👍
I have tested the PR locally and it seems to work well. I have left some in-line comments.
zulipterminal/ui_tools/views.py
Outdated
| @@ -1299,10 +1299,18 @@ def __init__(self, controller: Any, stream_id: int) -> None: | |||
| footlinks_width, | |||
| len(visual_notification.label) + 4, | |||
| ) | |||
| visual_notification = [visual_notification] | |||
There was a problem hiding this comment.
This is a bit unclear since you're reassigning another value in the var and later assigning another value conditionally. Could we call it something else?
| @@ -32,7 +32,6 @@ | |||
| 'column_title' : 'bold', | |||
| 'time' : '', | |||
| 'bar' : 'standout', | |||
| 'popup_contrast' : 'standout', | |||
There was a problem hiding this comment.
commit-description: so that it's*
This commit adds another style attribute "popup_important" for rendering hints/errors in the popup, or to justify the reason behind some popup elements being rendered differently/disabled. This also groups all the popup_* attributes together in all themes, so that it's easier to read and compare them.
This commit adds an extra Text widget in the stream settings indicating the user to configure or enable notifications if the checkbox is disabled. Currently, there are two ways to enable notifications in ZT: - Pass the --notify flag when starting ZT. - Add notify=enabled in the zuliprc file. See https://github.com/zulip/zulip-terminal#notifications for details on configuring notifications for your platform.
zee-bit
force-pushed
the
indicate-notification-setting-nuances
branch
from
45aab00 to
89ae3e1
Compare
|
@zee-bit Thanks for the prompt update following #900, I agree with @preetmishra that this will improve the UX 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This indicates more explicitly subtle details about the recently introduced Visual notification change via #900. Namely, we indicate that the "Visual notification" setting directly affects other clients such as Web app and desktop. Also, we remind the user
to configure/enable notifications if the checkbox is disabled.
Tested?
Commit flow
Notes & Questions
I have used "msg_mention" style attribute for the suffix text when the checkbox is disabled. Although this looks good visually on all themes, I'm concerned that the attr-name does not align with our context?