[WIP] Refactor keypress to follow urwid rules #1063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Rohitth007 wants to merge 13 commits into zulip:main from Rohitth007:refactor-keypress-rules

Collaborator

Rohitth007 commented Jul 3, 2021 •

edited

Loading

This PR changes the current keypress flow to follow urwid rules.
This is built on PR #974 would need PR #1060 to proceed.

Rohitth007 added 13 commits

July 2, 2021 17:15


          refactor: keys: Use urwid's CommandMap to manage navigational keys.

56830d5

This commit modifies urwid's `CommandMap` class object `command_map`
to map alternate navigational keys to standard urwid navigational
aliases. This is used in `ui.py` and `PopupView`.

Users can also now add custom nav-keys by adding it to KEY_BINDINGS.

Tests updated.


          refactor: Remove use of unnecessary class attributes.

4906af9

This commit:
* Changes old notation self.model.controller to self.controller


          Alternate UI tests

7a2f619


          tests: ui: Add tests for special narrow keypress.

455d5a0

Tests added for Special Narrow keypress actions in View.


          Make View inherit Frame

e92440b


          Add spaces after all keypress conditionals.

2ff1a77


          refactor View

ebdb614


          refactor Column's keypress

bbd1248


          Refactor Panel's keypress

10e1a11


          Refactor MessageView keypress

9971e5d


          Refactor popup keypress

d33766a


          refactor Boxes keypress

e8b6529


          Refactor button's keypress

Rohitth007 force-pushed the refactor-keypress-rules branch from 7f807f6 to 8427664 Compare

July 3, 2021 14:12

Rohitth007 added area: refactoring feedback wanted in progress PR awaiting update PR needs review and removed PR awaiting update labels

neiljp added the further discussion required label

Collaborator

neiljp commented Jul 5, 2021

@Rohitth007 I left a note in the topic on #zulip-terminal, let's discuss!

Member

zulipbot commented Jul 15, 2021

ERROR: This active issue has no assignee.

Rohitth007 mentioned this pull request

Panel refactor #1072

Open

3 tasks

Member

zulipbot commented Jul 19, 2021

ERROR: This active issue has no assignee.

5 similar comments

Member

zulipbot commented Jul 24, 2021

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 28, 2021

ERROR: This active issue has no assignee.

Member

zulipbot commented Aug 1, 2021

ERROR: This active issue has no assignee.

Member

zulipbot commented Aug 25, 2021

ERROR: This active issue has no assignee.

Member

zulipbot commented Aug 29, 2021

ERROR: This active issue has no assignee.

Member

zulipbot commented Apr 2, 2022

ERROR: This active issue has no assignee.

28 similar comments

Member

zulipbot commented Apr 6, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Apr 10, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Apr 15, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Apr 19, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Apr 23, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Apr 27, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 1, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 5, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 9, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 14, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 18, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 22, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 26, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented May 30, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 3, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 8, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 12, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 16, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 20, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 24, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jun 28, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 3, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 7, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 11, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 15, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 19, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 23, 2022

ERROR: This active issue has no assignee.

Member

zulipbot commented Jul 27, 2022

ERROR: This active issue has no assignee.

amanagr removed the in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: refactoring feedback wanted further discussion required has conflicts PR needs review