Wrong rendering of reaction removal if multiple already present

[neiljp]

• Find a message with multiple thumbs-up
• Toggle thumbs-up (+)
• Toggle again

One of those last two, depending on your previous thumbs-up reaction to that message, currently completely removes that reaction from being rendered - and would probably do the same for other reactions when we add that feature in future.

[kaustubh-nair]

@neiljp I can reproduce this but not all the time.
Sometimes it leads to different behaviour
This is what happens:

• Find a message with multiple thumbs-up
• Toggle thumbs-up (+)
• Toggle again to remove thumbs-up
• Previous thumbs-ups remain, but now I cannot add my thumbs up again.

[preetmishra]

I suspect that the reason is the following code block in model.py. There are two key issues here:

• it removes all the reactions (we could warrant a break),
• it removes whichever reaction it finds first (the comment has an explanation).

zulip-terminal/zulipterminal/model.py

Lines 840 to 844 in 7bc9da6

	for reaction in message['reactions']:
	# Since Who reacted is not displayed,
	# remove the first one encountered
	if reaction['emoji_code'] == emoji_code:
	message['reactions'].remove(reaction)