Consider changes needed/possible when Python3.5 reaches end of life

[neiljp]

Possible changes at this point, once we remove support for Python 3.5:

• Remove explicit zipp version from install files (pinned as it dropped 3.5 support already)
• Migrate type comments to type annotations for variables (automate this?)
• Migrate to f-strings where appropriate (automate this?)

Current end of life (EOL) will be 2020-09-13 according to https://devguide.python.org/#status-of-python-branches

For other thoughts on this, please discuss on #zulip-terminal at chat.zulip.org

[neiljp]

Automation of some aspects can be made using:

• https://github.com/asottile/pyupgrade - with appropriate parameters (f-strings & others)
• https://github.com/ilevkivskyi/com2ann - (comments to variables)

[neiljp]

Also https://github.com/jacktasia/fstringify for %-style strings to f-strings, but I'm not sure we really use this much.

[neiljp]

Progress towards this is ongoing in #838

[Ezio-Sarthak]

I think the only aspect left for this issue is the migration from type comments to type annotations?

A quick git grep shows there are 7 type comments existing. The tool you mentioned seems cool! Since there aren't many cases existing now, we may think of automation later?

[neiljp]

I'm closing this now, since we've applied this to the code and tests.

[zulipbot]

Hello @zulip/server-refactoring members, this issue was labeled with the "area: refactoring" label, so you may want to check it out!