-
-
Notifications
You must be signed in to change notification settings - Fork 643
fix(graphql): replace deprecated hive with hive_ce package #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(graphql): replace deprecated hive with hive_ce package #1499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the graphql-flutter package to use the community-maintained hive_ce package instead of the deprecated hive package for caching functionality. The change addresses potential security and maintenance issues by migrating to an actively maintained fork that provides the same API.
- Replaced deprecated
hivepackage withhive_cein dependency declarations - Updated import statements to reference the new package
- Maintained complete backward compatibility with existing functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/graphql_flutter/pubspec.yaml | Updated dependency from hive ^2.0.0 to hive_ce ^2.11.3 |
| packages/graphql/pubspec.yaml | Updated dependency from hive ^2.1.0 to hive_ce ^2.11.3 |
| packages/graphql/lib/src/cache/hive_store.dart | Updated import statement to use hive_ce package |
|
please can you fix the commit messages and check the copilot review? rules for the commit messages are https://zino-hofmann.github.io/graphql-flutter/docs/dev/MAINTAINERS.html |
87b8b48 to
6226607
Compare
Thank you for the PR feedback! I’ve updated the commit messages and applied the Copilot review suggestions as you recommended. |
|
@korca0220 please look at the docs, we do not have |
989bdd6 to
6226607
Compare
Sorry, I missed checking it. I've reflected the changes now. |
|
Thanks, the build and tests are failing for some reason, but I will be happy to merge when the CI is happy and release ti under a beta version for a while, thanks for doing this |
Thank you! I've fixed those issues. |
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGMT
Description
This PR replaces the deprecated
hivepackage withhive_ce(Community Edition) to ensure continued maintenance and support for the caching functionality in graphql-flutter.Why should this be merged?
The original
hivepackage has been archived and is no longer maintained by its original authors. This creates potential security and compatibility issues for projects depending on it. Thehive_cepackage is a community-maintained fork that:Changes Made
packages/graphql/pubspec.yamlto usehive_ceinstead ofhivepackages/graphql_flutter/pubspec.yamlto usehive_ceinstead ofhivepackages/graphql/lib/src/cache/hive_store.dartTesting
Breaking changes
None - This is a drop-in replacement that maintains the same API.
Fixes / Enhancements