Skip to content

Conversation

@korca0220
Copy link
Contributor

Description

This PR replaces the deprecated hive package with hive_ce (Community Edition) to ensure continued maintenance and support for the caching functionality in graphql-flutter.

Why should this be merged?

The original hive package has been archived and is no longer maintained by its original authors. This creates potential security and compatibility issues for projects depending on it. The hive_ce package is a community-maintained fork that:

  • Provides the same API and functionality as the original hive package
  • Is actively maintained with bug fixes and improvements
  • Ensures long-term stability for graphql-flutter's caching features
  • Maintains backward compatibility with existing code

Changes Made

  • Updated packages/graphql/pubspec.yaml to use hive_ce instead of hive
  • Updated packages/graphql_flutter/pubspec.yaml to use hive_ce instead of hive
  • Updated import statements in packages/graphql/lib/src/cache/hive_store.dart
  • All existing functionality remains unchanged
  • Backward compatibility is maintained

Testing

  • All existing tests pass
  • Cache functionality works as expected
  • No breaking changes to public API
  • CI passes successfully

Breaking changes

None - This is a drop-in replacement that maintains the same API.

Fixes / Enhancements

  • Fixed potential security and maintenance issues by replacing deprecated package
  • Enhanced long-term stability of the caching system
  • Updated to actively maintained package version

@vincenzopalazzo vincenzopalazzo requested a review from Copilot August 7, 2025 11:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the graphql-flutter package to use the community-maintained hive_ce package instead of the deprecated hive package for caching functionality. The change addresses potential security and maintenance issues by migrating to an actively maintained fork that provides the same API.

  • Replaced deprecated hive package with hive_ce in dependency declarations
  • Updated import statements to reference the new package
  • Maintained complete backward compatibility with existing functionality

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/graphql_flutter/pubspec.yaml Updated dependency from hive ^2.0.0 to hive_ce ^2.11.3
packages/graphql/pubspec.yaml Updated dependency from hive ^2.1.0 to hive_ce ^2.11.3
packages/graphql/lib/src/cache/hive_store.dart Updated import statement to use hive_ce package

@vincenzopalazzo
Copy link
Collaborator

please can you fix the commit messages and check the copilot review?

rules for the commit messages are https://zino-hofmann.github.io/graphql-flutter/docs/dev/MAINTAINERS.html

@korca0220 korca0220 force-pushed the feat/change-dependency-hive branch 2 times, most recently from 87b8b48 to 6226607 Compare August 8, 2025 01:51
@korca0220
Copy link
Contributor Author

please can you fix the commit messages and check the copilot review?

rules for the commit messages are https://zino-hofmann.github.io/graphql-flutter/docs/dev/MAINTAINERS.html

Thank you for the PR feedback! I’ve updated the commit messages and applied the Copilot review suggestions as you recommended.

@vincenzopalazzo
Copy link
Collaborator

@korca0220 please look at the docs, we do not have chrore and we do not support multiple name in ()

@korca0220 korca0220 force-pushed the feat/change-dependency-hive branch from 989bdd6 to 6226607 Compare August 8, 2025 13:06
@korca0220
Copy link
Contributor Author

korca0220 commented Aug 8, 2025

@korca0220 please look at the docs, we do not have chrore and we do not support multiple name in ()

Sorry, I missed checking it. I've reflected the changes now.

@vincenzopalazzo
Copy link
Collaborator

Thanks, the build and tests are failing for some reason, but I will be happy to merge when the CI is happy and release ti under a beta version for a while, thanks for doing this

@korca0220
Copy link
Contributor Author

Thanks, the build and tests are failing for some reason, but I will be happy to merge when the CI is happy and release ti under a beta version for a while, thanks for doing this

Thank you! I've fixed those issues.

Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGMT

@vincenzopalazzo vincenzopalazzo merged commit d533f70 into zino-hofmann:main Sep 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants