Fix device diagnostics not regenerating with changed quirks #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #455 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 63 63
Lines 10355 10355
=======================================
Hits 10036 10036
Misses 319 319 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes an issue where regenerating device diagnostics or importing legacy device diagnostics might not work if
cluster_detailsstill contains clusters that are no longer present on theDeviceobject.Additional information
This can be caused when a quirk no longer exposes a certain cluster.
Noticed here: zigpy/zha-device-handlers#3232 (comment)
Draft until this is ready, as I've also had the same issue not just when regenerating diagnostics, but also when importing legacy diagnostics, though I just removed the clusters from the JSON for now.
I'll come back to this later.