Skip to content

Upgrade to 1.92.1 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade to 1.92.1 #51

wants to merge 4 commits into from

Conversation

kcbanner
Copy link
Contributor

@kcbanner kcbanner commented Jul 20, 2025 •
edited
Loading

  • Upgrade to 1.92.1
  • Add TextureRef and update related APIs
  • Set IMGUI_DISABLE_OBSOLETE_FUNCTIONS and remove usage of deprecated functions
  • Fixup deprecated API usages (callconv, alignment)

Remaining TODOs:

  • Update test engine
  • Update node editor

kcbanner added 2 commits July 22, 2025 00:42
@kcbanner
- Upgrade to 1.92.1
1c0b2c7 
- Add TextureRef and update related APIs
- Set IMGUI_DISABLE_OBSOLETE_FUNCTIONS and remove usage of deprecated functions
- Fixup deprecated API usages (callconv, alignment)
@kcbanner
- Bump minimum zig version (for std.mem.Alignment usage)
523a8ae
@kcbanner kcbanner marked this pull request as ready for review July 29, 2025 04:13
@kcbanner
Copy link
Contributor Author

This is ready for review, but currently the build.zig.zon points to my forks for these changes: zig-gamedev/zsdl#24 and zig-gamedev/zgpu#18.

I'll update the build.zig.zon once those are merged.

@a-day-old-bagel
Copy link
Member

a-day-old-bagel commented Aug 4, 2025 •
edited
Loading

I merged some of this into my own zgui fork so that I could test it against the zgpu changes I've been making.

There are a few things that might have to be addressed later, but there was one thing I noticed which surely can be fixed right away - in zgui.cpp, there are some lingering usages of ImTextureID which I think should have been changed to ImTextureRef, but were maybe overlooked.

I'll just link to the commit where I fixed them on my own fork to show you what I'm talking about:

a-day-old-bagel@f021b1c

If these changes aren't made, using the affected functions will crash due to ABI mismatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kcbanner @a-day-old-bagel