Thank you contributors#125
Thank you contributors#125zhravan merged 3 commits intozhravan:mainfrom version0chiro:thank_you_contributors
Conversation
|
Thank you for your time to contribute towards our feature request. We will review your code, and accept the PR. Also, will you please add the screenshot of the whole screen with this component? |
zhravan
added
enhancement
|
Hey @Shravan20 , this is how the screen looks with the component, I was a bit unsure about the placement but can easily change if you have any specific place you wanna keep it at. |
|
Hi @version0chiro |
| const ContributorsCard = () => { | ||
| const [listOfContributors,setListOfContributors] = useState([]); | ||
| useEffect(()=>{ | ||
| fetch("https://api.github.com/repos/shravan20/github-readme-quotes/contributors?") |
There was a problem hiding this comment.
Can you move the URL to a urlConfig.js file and export it from there under a new folder called /constants?? This is to ensure that we maintain code quality. Please make the changes by evening, we will have it accepted by evening.
There was a problem hiding this comment.
okay no problem in that, can i make the folder inside the Contributors Card or do you want it to be in the components?
There was a problem hiding this comment.
Create a folder /frontend/src/CONSTANTS.
Create a file urlConfig.js. Just move URL to that!
Rest of the things looks neat!
There was a problem hiding this comment.
I have exported the URL from a new file, kindly check the changes in the latest commit
2 participants
Added a material UI based thank you card at the bottom of the page. Also extracted the current count of contributors using GitHub's API and displayed top 6 avatars who have contributed to the project. This is how the card looks.
I have added a separate component for the card for easy editing and reviewing. Kindly check the Contributors card in the front end directory. I am unsure how to proceed forward with the building of front end to the server, would be great if someone can help me with that, thank you.