Skip to content

Do not use an explicit user for ssh when deploymentUser is null#91

Merged
zhaofengli merged 2 commits intozhaofengli:mainfrom
dminuoso:ssh-without-user
Jun 2, 2022
Merged

Do not use an explicit user for ssh when deploymentUser is null#91
zhaofengli merged 2 commits intozhaofengli:mainfrom
dminuoso:ssh-without-user

Conversation

@dminuoso
Copy link
Contributor

@dminuoso dminuoso commented Jun 1, 2022

Right now colmena will statically emit the current user in the user@host target, preventing the usage of .ssh/config or equivalent of overriding the username.

In situations where a repository is shared with multiple people such that configuring deploymentUser in the repository is unfeasible, this makes it easier when certain remote machines demand a particular user that is different from the local user.

This also addresses #61

@zhaofengli
Copy link
Owner

Thanks! Could you also update the cargoSha256 in package.nix so nix-build works (see error for instructions)? To make things easier, we can also move back to cargoLock.lockFile since we are no longer pulling the git version of indicatif.

@dminuoso
Copy link
Contributor Author

dminuoso commented Jun 2, 2022

Done!

@zhaofengli
Copy link
Owner

Thanks again!

@zhaofengli zhaofengli merged commit 66d65b6 into zhaofengli:main Jun 2, 2022
zhaofengli added a commit that referenced this pull request Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants