Do not use an explicit user for ssh when deploymentUser is null#91
Merged
zhaofengli merged 2 commits intozhaofengli:mainfrom Jun 2, 2022
Merged
Do not use an explicit user for ssh when deploymentUser is null#91zhaofengli merged 2 commits intozhaofengli:mainfrom
zhaofengli merged 2 commits intozhaofengli:mainfrom
Conversation
Owner
|
Thanks! Could you also update the |
Contributor
Author
|
Done! |
Owner
|
Thanks again! |
zhaofengli
added a commit
that referenced
this pull request
Jun 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now colmena will statically emit the current user in the
user@hosttarget, preventing the usage of .ssh/config or equivalent of overriding the username.In situations where a repository is shared with multiple people such that configuring deploymentUser in the repository is unfeasible, this makes it easier when certain remote machines demand a particular user that is different from the local user.
This also addresses #61