Skip to content

apply_local: Fix nixos detection from os-release#63

Merged
zhaofengli merged 1 commit intozhaofengli:mainfrom
glenn-m:main
Mar 8, 2022
Merged

apply_local: Fix nixos detection from os-release#63
zhaofengli merged 1 commit intozhaofengli:mainfrom
glenn-m:main

Conversation

@glenn-m
Copy link
Contributor

@glenn-m glenn-m commented Mar 8, 2022

This fixes apply-local not detecting the system as NixOS due to the changes in the format of the os-release file.

Details on the changes made to the os-release file can be found in the following commit NixOS/nixpkgs@bae181d.

I'm new to Rust so let me know if I've missed anything, thanks!

@zhaofengli
Copy link
Owner

Nice, thanks for catching this! I haven't updated so I didn't encounter this, but we should have some automation to auto-bump the nixpkgs input and run the apply-local test so we can catch breakages like this sooner.

I'll backport this to 0.2 in a bit.

@zhaofengli zhaofengli merged commit 9c179b0 into zhaofengli:main Mar 8, 2022
zhaofengli added a commit that referenced this pull request Mar 8, 2022
This release fixes NixOS detection so `apply-local` works with the latest
changes in nixos-unstable (#63). Additionally, `--no-keys` was fixed in
`apply-local`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants