Revert "modules: nrf_wifi: Disable anomalies for both QSPIs" #92053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4660f4c. The reverted commit disabled workarounds for XIP-related anomalies for configurations where CONFIG_NORDIC_QSPI_NOR was enabled. This caused memory issues on custom boards that were using a combination of nRF5340 SOC, nRF7002 WiFi chip and XIP over QSPI. Memory issues manifested as usage faults, where the PC in the esf pointer given to the k_sys_fatal_error_handler would always point to an address somewhere in the external flash, however the address would slightly change between reboots. The memory issues were discovered during NCS migration, migrating from v2.7.0 to v3.0.1. By reverting the commit we re-enable the workarounds for the cases where CONFIG_NORDIC_QSPI_NOR is enabled. Signed-off-by: Marko Sagadin <[email protected]>
|
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "modules: nrf_wifi: Disable anomalies for both QSPIs"
This reverts commit 4660f4c.
The reverted commit disabled workarounds for XIP-related anomalies for
configurations where CONFIG_NORDIC_QSPI_NOR was enabled. This caused
memory issues on custom boards that were using a combination of nRF5340
SOC, nRF7002 WiFi chip and XIP over QSPI.
Memory issues manifested as usage faults, where the PC in the esf
pointer given to the k_sys_fatal_error_handler would always point to
an address somewhere in the external flash, however the address would
slightly change between reboots.
The memory issues were discovered during NCS migration, migrating from
v2.7.0 to v3.0.1.
By reverting the commit we re-enable the workarounds for the cases where
CONFIG_NORDIC_QSPI_NOR is enabled.
Tagging @krish2718, as he will probably have the most knowledge if this revert makes sense.
I have also found a recent DevZone issue that was solved by applying the 159 workaround, although their symptoms looked different from mine: https://devzone.nordicsemi.com/f/nordic-q-a/122110/nrf5340-nrfx_qspi-sdk-v3-0-1-peripheral-issue/538508