device: increase consistency in device declarations #25712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pabigot
requested review from
avisconti,
dcpleung,
jukkar,
mnkp,
nashif,
nordic-krch,
pfalcon,
tbursztyka and
wentongwu
as code owners
tbursztyka
approved these changes
May 28, 2020
zephyrbot
added
area: Watchdog
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
jukkar
approved these changes
May 28, 2020
dcpleung
approved these changes
May 28, 2020
wentongwu
approved these changes
May 29, 2020
nashif
approved these changes
May 29, 2020
nordic-krch
approved these changes
May 29, 2020
Replace individual device instance definitions with the macro that
expands to the equivalent change.
F='struct device DEVICE_NAME_GET'
git grep -l "$F" \
| xargs sed -i -r \
-e "s@$F"'\(([^)]*)\);@DEVICE_DECLARE(\1);@'
Signed-off-by: Peter Bigot <[email protected]>
Avoid duplication of the encoding of the public device identifier by using the constructing macro in definitions. Signed-off-by: Peter Bigot <[email protected]>
|
Could somebody please merge? I'm starting to investigate techniques for device handles, and making the declarations more uniform will simplify the refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two patches (updated) from #25208 to make it easier to locate and possibly transform existing device declarations by using existing helper macros consistently in places where currently the value they expand to is used directly.
Specifically
DEVICE_NAME_GET()is used rather than prepending__device_to the device name, andDEVICE_DECLAREis used rather than an explicit declararation.