[RFC] API change: Device - Const-ify device driver instances.

arch/arc/core/arc_smp.c

@@ -87,7 +87,7 @@ void z_arc_slave_start(int cpu_num)
 
 #ifdef CONFIG_SMP
 
-static void sched_ipi_handler(void *unused)
+static void sched_ipi_handler(const void *unused)
 {
 	ARG_UNUSED(unused);
 
@@ -108,7 +108,7 @@ void arch_sched_ipi(void)
 	}
 }
 
-static int arc_smp_init(struct device *dev)
+static int arc_smp_init(const struct device *dev)
 {
 	ARG_UNUSED(dev);
 	struct arc_connect_bcr bcr;

arch/arc/core/cache.c

@@ -149,7 +149,7 @@ size_t arch_cache_line_size_get(void)
 #endif
 }
 
-static int init_dcache(struct device *unused)
+static int init_dcache(const struct device *unused)
 {
 	ARG_UNUSED(unused);
 

arch/arc/core/irq_manage.c

@@ -165,16 +165,16 @@ void z_irq_priority_set(unsigned int irq, unsigned int prio, uint32_t flags)
  * @return N/A
  */
 
-void z_irq_spurious(void *unused)
+void z_irq_spurious(const void *unused)
 {
 	ARG_UNUSED(unused);
 	z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL);
 }
 
 #ifdef CONFIG_DYNAMIC_INTERRUPTS
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-			     void (*routine)(void *parameter), void *parameter,
-			     uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	z_isr_install(irq, routine, parameter);
 	z_irq_priority_set(irq, priority, flags);

arch/arc/core/irq_offload.c

@@ -12,15 +12,15 @@
 #include <irq_offload.h>
 
 static irq_offload_routine_t offload_routine;
-static void *offload_param;
+static const void *offload_param;
 
 /* Called by trap_s exception handler */
 void z_irq_do_offload(void)
 {
 	offload_routine(offload_param);
 }
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 
 	offload_routine = routine;

arch/arc/core/mpu/arc_mpu_v2_internal.h

@@ -374,7 +374,7 @@ int arc_core_mpu_buffer_validate(void *addr, size_t size, int write)
  * This function provides the default configuration mechanism for the Memory
  * Protection Unit (MPU).
  */
-static int arc_mpu_init(struct device *arg)
+static int arc_mpu_init(const struct device *arg)
 {
 	ARG_UNUSED(arg);
 

arch/arc/core/mpu/arc_mpu_v3_internal.h

@@ -824,7 +824,7 @@ int arc_core_mpu_buffer_validate(void *addr, size_t size, int write)
  * This function provides the default configuration mechanism for the Memory
  * Protection Unit (MPU).
  */
-static int arc_mpu_init(struct device *arg)
+static int arc_mpu_init(const struct device *arg)
 {
 	ARG_UNUSED(arg);
 	uint32_t num_regions;

arch/arc/core/secureshield/arc_sjli.c

@@ -48,7 +48,7 @@ static void sjli_table_init(void)
 /*
  * @brief initializaiton of secureshield related functions.
  */
-static int arc_secureshield_init(struct device *arg)
+static int arc_secureshield_init(const struct device *arg)
 {
 	sjli_table_init();
 

arch/arm/core/aarch32/cortex_m/mpu/arm_mpu.c

@@ -300,7 +300,7 @@ void arm_core_mpu_configure_dynamic_mpu_regions(const struct k_mem_partition
  * This function provides the default configuration mechanism for the Memory
  * Protection Unit (MPU).
  */
-static int arm_mpu_init(struct device *arg)
+static int arm_mpu_init(const struct device *arg)
 {
 	uint32_t r_index;
 

arch/arm/core/aarch32/cortex_m/mpu/nxp_mpu.c

@@ -598,7 +598,7 @@ void arm_core_mpu_configure_dynamic_mpu_regions(const struct k_mem_partition
  * This function provides the default configuration mechanism for the Memory
  * Protection Unit (MPU).
  */
-static int nxp_mpu_init(struct device *arg)
+static int nxp_mpu_init(const struct device *arg)
 {
 	ARG_UNUSED(arg);
 

arch/arm/core/aarch32/irq_manage.c

@@ -154,7 +154,7 @@ void z_arm_fatal_error(unsigned int reason, const z_arch_esf_t *esf);
  *
  * @return N/A
  */
-void z_irq_spurious(void *unused)
+void z_irq_spurious(const void *unused)
 {
 	ARG_UNUSED(unused);
 
@@ -257,8 +257,8 @@ int irq_target_state_is_secure(unsigned int irq)
 
 #ifdef CONFIG_DYNAMIC_INTERRUPTS
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-			     void (*routine)(void *parameter), void *parameter,
-			     uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	z_isr_install(irq, routine, parameter);
 	z_arm_irq_priority_set(irq, priority, flags);

arch/arm/core/aarch32/irq_offload.c

@@ -12,15 +12,15 @@
 #include <irq_offload.h>
 
 volatile irq_offload_routine_t offload_routine;
-static void *offload_param;
+static const void *offload_param;
 
 /* Called by z_arm_svc */
 void z_irq_do_offload(void)
 {
 	offload_routine(offload_param);
 }
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 #if defined(CONFIG_ARMV6_M_ARMV8_M_BASELINE) && defined(CONFIG_ASSERT)
 	/* ARMv6-M/ARMv8-M Baseline HardFault if you make a SVC call with

arch/arm/core/aarch64/arm_mmu.c

@@ -426,7 +426,7 @@ static void enable_mmu_el1(unsigned int flags)
  * This function provides the default configuration mechanism for the Memory
  * Management Unit (MMU).
  */
-static int arm_mmu_init(struct device *arg)
+static int arm_mmu_init(const struct device *arg)
 {
 	uint64_t val;
 	unsigned int idx, flags = 0;

arch/arm/core/aarch64/irq_manage.c

@@ -55,16 +55,16 @@ void z_arm64_irq_priority_set(unsigned int irq, unsigned int prio, uint32_t flag
 
 #ifdef CONFIG_DYNAMIC_INTERRUPTS
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-			     void (*routine)(void *parameter), void *parameter,
-			     uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	z_isr_install(irq, routine, parameter);
 	z_arm64_irq_priority_set(irq, priority, flags);
 	return irq;
 }
 #endif
 
-void z_irq_spurious(void *unused)
+void z_irq_spurious(const void *unused)
 {
 	ARG_UNUSED(unused);
 

arch/arm/core/aarch64/irq_offload.c

@@ -14,14 +14,14 @@
 #include <aarch64/exc.h>
 
 volatile irq_offload_routine_t offload_routine;
-static void *offload_param;
+static const void *offload_param;
 
 void z_irq_do_offload(void)
 {
 	offload_routine(offload_param);
 }
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 	k_sched_lock();
 	offload_routine = routine;

arch/common/gen_isr_tables.py

@@ -61,7 +61,7 @@ def read_intlist(intlist_path, syms):
         /** ISR to call */
         void *func;
         /** Parameter for non-direct IRQs */
-        void *param;
+        const void *param;
     };
     """
 
@@ -175,7 +175,7 @@ def write_source_file(fp, vt, swt, intlist, syms):
             fp.write("\t/* Level 3 interrupts start here (offset: {}) */\n".
                      format(level3_offset))
 
-        fp.write("\t{{(void *){0:#x}, (void *){1}}},\n".format(param, func_as_string))
+        fp.write("\t{{(const void *){0:#x}, (void *){1}}},\n".format(param, func_as_string))
     fp.write("};\n")
 
 def get_symbols(obj):

arch/common/isr_tables.c

@@ -60,6 +60,7 @@ uint32_t __irq_vector_table _irq_vector_table[IRQ_TABLE_SIZE] = {
  */
 #ifdef CONFIG_GEN_SW_ISR_TABLE
 struct _isr_table_entry __sw_isr_table _sw_isr_table[IRQ_TABLE_SIZE] = {
-	[0 ...(IRQ_TABLE_SIZE - 1)] = {(void *)0x42, (void *)&z_irq_spurious},
+	[0 ...(IRQ_TABLE_SIZE - 1)] = {(const void *)0x42,
+				       (void *)&z_irq_spurious},
 };
 #endif

arch/common/sw_isr_common.c

@@ -70,7 +70,8 @@ unsigned int get_parent_offset(unsigned int parent_irq,
 
 #endif /* CONFIG_MULTI_LEVEL_INTERRUPTS */
 
-void z_isr_install(unsigned int irq, void (*routine)(void *), void *param)
+void z_isr_install(unsigned int irq, void (*routine)(const void *),
+		   const void *param)
 {
 	unsigned int table_idx;
 
@@ -127,8 +128,8 @@ void z_isr_install(unsigned int irq, void (*routine)(void *), void *param)
  */
 int __weak arch_irq_connect_dynamic(unsigned int irq,
 				    unsigned int priority,
-				    void (*routine)(void *),
-				    void *parameter,
+				    void (*routine)(const void *),
+				    const void *parameter,
 				    uint32_t flags)
 {
 	ARG_UNUSED(flags);

arch/nios2/core/irq_manage.c

@@ -22,7 +22,7 @@
 #include <logging/log.h>
 LOG_MODULE_DECLARE(os);
 
-FUNC_NORETURN void z_irq_spurious(void *unused)
+FUNC_NORETURN void z_irq_spurious(const void *unused)
 {
 	ARG_UNUSED(unused);
 	LOG_ERR("Spurious interrupt detected! ipending: %x",
@@ -121,8 +121,8 @@ void _enter_irq(uint32_t ipending)
 
 #ifdef CONFIG_DYNAMIC_INTERRUPTS
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-			     void (*routine)(void *parameter), void *parameter,
-			     uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	ARG_UNUSED(flags);
 	ARG_UNUSED(priority);

arch/nios2/core/irq_offload.c

@@ -9,7 +9,7 @@
 #include <irq_offload.h>
 
 volatile irq_offload_routine_t _offload_routine;
-static volatile void *offload_param;
+static volatile const void *offload_param;
 
 /* Called by _enter_irq if it was passed 0 for ipending.
  * Just in case the offload routine itself generates an unhandled
@@ -26,10 +26,10 @@ void z_irq_do_offload(void)
 	tmp = _offload_routine;
 	_offload_routine = NULL;
 
-	tmp((void *)offload_param);
+	tmp((const void *)offload_param);
 }
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 	unsigned int key;
 

arch/posix/core/irq.c

@@ -10,7 +10,7 @@
 #ifdef CONFIG_IRQ_OFFLOAD
 #include "irq_offload.h"
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 	posix_irq_offload(routine, parameter);
 }
@@ -46,8 +46,8 @@ int arch_irq_is_enabled(unsigned int irq)
  * @return The vector assigned to this interrupt
  */
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-			     void (*routine)(void *parameter),
-			     void *parameter, uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	posix_isr_declare(irq, (int)flags, routine, parameter);
 	posix_irq_priority_set(irq, priority, flags);

arch/riscv/core/irq_manage.c

@@ -9,7 +9,7 @@
 #include <logging/log.h>
 LOG_MODULE_DECLARE(os);
 
-FUNC_NORETURN void z_irq_spurious(void *unused)
+FUNC_NORETURN void z_irq_spurious(const void *unused)
 {
 	ulong_t mcause;
 
@@ -31,8 +31,8 @@ FUNC_NORETURN void z_irq_spurious(void *unused)
 
 #ifdef CONFIG_DYNAMIC_INTERRUPTS
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-			     void (*routine)(void *parameter), void *parameter,
-			     uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	ARG_UNUSED(flags);
 

arch/riscv/core/irq_offload.c

@@ -9,7 +9,7 @@
 #include <sys/printk.h>
 
 volatile irq_offload_routine_t _offload_routine;
-static volatile void *offload_param;
+static volatile const void *offload_param;
 
 /*
  * Called by _enter_irq
@@ -28,10 +28,10 @@ void z_irq_do_offload(void)
 	tmp = _offload_routine;
 	_offload_routine = NULL;
 
-	tmp((void *)offload_param);
+	tmp((const void *)offload_param);
 }
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 	unsigned int key;
 

arch/x86/core/ia32/cache.c

@@ -86,7 +86,7 @@ size_t arch_cache_line_size_get(void)
 #endif
 }
 
-static int init_cache(struct device *unused)
+static int init_cache(const struct device *unused)
 {
 	ARG_UNUSED(unused);
 

arch/x86/core/ia32/irq_manage.c

@@ -56,9 +56,9 @@ extern unsigned int z_interrupt_vectors_allocated[];
 
 struct dyn_irq_info {
 	/** IRQ handler */
-	void (*handler)(void *param);
+	void (*handler)(const void *param);
 	/** Parameter to pass to the handler */
-	void *param;
+	const void *param;
 };
 
 /*
@@ -197,8 +197,8 @@ static void idt_vector_install(int vector, void *irq_handler)
 }
 
 int arch_irq_connect_dynamic(unsigned int irq, unsigned int priority,
-		void (*routine)(void *parameter), void *parameter,
-		uint32_t flags)
+			     void (*routine)(const void *parameter),
+			     const void *parameter, uint32_t flags)
 {
 	int vector, stub_idx, key;
 

arch/x86/core/ia32/irq_offload.c

@@ -17,15 +17,15 @@ NANO_CPU_INT_REGISTER(_irq_sw_handler, NANO_SOFT_IRQ,
 		      CONFIG_IRQ_OFFLOAD_VECTOR, 0);
 
 static irq_offload_routine_t offload_routine;
-static void *offload_param;
+static const void *offload_param;
 
 /* Called by asm stub */
 void z_irq_do_offload(void)
 {
 	offload_routine(offload_param);
 }
 
-void arch_irq_offload(irq_offload_routine_t routine, void *parameter)
+void arch_irq_offload(irq_offload_routine_t routine, const void *parameter)
 {
 	unsigned int key;