Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

flatten cookies for header #92

Merged
merged 8 commits into from
Jan 25, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/Header/Cookie.php
Original file line number Diff line number Diff line change
Expand Up @@ -97,13 +97,28 @@ public function getFieldValue()
{
$nvPairs = [];

foreach ($this as $name => $value) {
foreach ($this->flattenCookies($this) as $name => $value) {
$nvPairs[] = $name . '=' . (($this->encodeValue) ? urlencode($value) : $value);
}

return implode('; ', $nvPairs);
}

protected function flattenCookies($data, $prefix = null)
{
$result = [];
foreach ($data as $key => $value) {
$key = $prefix ? $prefix . '[' . $key . ']' : $key;
if (is_array($value)) {
$result = array_merge($result, $this->flattenCookies($value, $key));
} else {
$result[$key] = $value;
}
}

return $result;
}

public function toString()
{
return 'Cookie: ' . $this->getFieldValue();
Expand Down
17 changes: 17 additions & 0 deletions test/CookiesTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
use Zend\Http\Response;
use Zend\Http\Headers;
use Zend\Http\Cookies;
use Zend\Http\PhpEnvironment\Request;

class CookiesTest extends \PHPUnit_Framework_TestCase
{
Expand Down Expand Up @@ -43,4 +44,20 @@ public function testFromResponseInCookie()
$response = Cookies::fromResponse($response, "http://www.zend.com");
$this->assertSame($header, $response->getCookie('http://www.zend.com', 'foo'));
}

public function testRequestCanHaveArrayCookies()
{
// this happens wich cookie header: "test[a]=value_a&test[b]=value_b"
$_COOKIE = [
'test' => [
'a' => 'value_a',
'b' => 'value_b'
]
];
$request = new Request();

$fieldValue = $request->getCookie('test')->getFieldValue();

$this->assertSame('test[a]=value_a; test[b]=value_b', $fieldValue);
}
}