Skip to content
This repository was archived by the owner on Jan 30, 2020. It is now read-only.

Added certainty to suggest #135

Merged
merged 1 commit into from
Apr 26, 2018
Merged

Conversation

carnage
Copy link
Contributor

@carnage carnage commented Oct 25, 2017

Adds https://github.com/paragonie/certainty to the composer suggest.

Will be playing with a PR to add direct support to the adaptors but I consider this as a minimum step to help users write secure code.

@Xerkus
Copy link
Member

Xerkus commented Oct 26, 2017

It will be 👎 from me.
While I know of the guy and I trust he have security expertise, I cannot put trust into his keys for something as important as certificate authority keys. For the same reason I am against well known framework endorsing such trust for its users.

@asgrim
Copy link
Contributor

asgrim commented Oct 26, 2017

Interesting, and good point there @Xerkus - I'd be interested to hear from @ezimuel on this one.

From my perspective, it's about trust, and by adding the suggest, it's essentially an endorsement. I know Scott is doing a stellar job of pushing security in PHP, and this is a good thing to make things simpler...

@carnage
Copy link
Contributor Author

carnage commented Oct 26, 2017

It is all about trust, but the question becomes who should you trust with this responsibility? Your OS, your web host? Perhaps Zend could maintain a fork signed with their own keys?

@Xerkus
Copy link
Member

Xerkus commented Oct 26, 2017

@carnage In the environment I can control it is part of infrastructure automation. Using mozilla as a source with the help of curl provided script to fetch and convert certdata. In fedora ca-certificates package is good enough for me - same mozilla CA bundle, but updated twice a year.
In the environment I can't control... is that still a thing in 2017?

Result is pretty much the same as with certainty, except no middleman to rely on, it is done outside of php and resulting bundle file is not writable by php user.

@carnage
Copy link
Contributor Author

carnage commented Oct 27, 2017

Another question to ask is:

Given that some users do not do what your suggesting due to lack of knowledge or time, which protects them more: them disabling CA verification because it breaks their app or them using certainty to manage that problem for them?

Sure there are better ways to manage certificates, but something is better than nothing.

@weierophinney weierophinney merged commit 6b9ee94 into zendframework:master Apr 26, 2018
weierophinney added a commit that referenced this pull request Apr 26, 2018
Added certainty to suggest
weierophinney added a commit that referenced this pull request Apr 26, 2018
weierophinney added a commit that referenced this pull request Apr 26, 2018
weierophinney added a commit that referenced this pull request Apr 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants