Skip to content
This repository was archived by the owner on Jan 29, 2020. It is now read-only.

Fixed class generator ignoring use aliases for extended class #144

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/Generator/ClassGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,20 @@ private function generateShortOrCompleteClassname($fqnClassName)
$classNamespace = implode('\\', $parts);
$currentNamespace = (string) $this->getNamespaceName();

if ($this->hasUseAlias($fqnClassName)) {
return $this->traitUsageGenerator->getUseAlias($fqnClassName);
}
if ($this->hasUseAlias($classNamespace)) {
$namespaceAlias = $this->traitUsageGenerator->getUseAlias($classNamespace);

return $namespaceAlias . '\\' . $className;
}
if ($this->traitUsageGenerator->isUseAlias($fqnClassName)) {
return $fqnClassName;
}
if ($this->traitUsageGenerator->isUseAlias($classNamespace)) {
return $fqnClassName;
}
if ($classNamespace === $currentNamespace || in_array($fqnClassName, $this->getUses())) {
return $className;
}
Expand Down
34 changes: 34 additions & 0 deletions src/Generator/TraitUsageGenerator.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,40 @@ public function hasUseAlias($use)
return false;
}

/**
* Returns the alias of the provided FQCN
*
* @param string $use
* @return string|null
*/
public function getUseAlias(string $use): ?string
{
foreach ($this->uses as $key => $value) {
$parts = explode(' as ', $key);
if ($parts[0] === $use && count($parts) == 2) {
return $parts[1];
}
}
return null;
}

/**
* Returns true if the alias is defined in the use list
*
* @param string $alias
* @return bool
*/
public function isUseAlias(string $alias): bool
{
foreach ($this->uses as $key => $value) {
$parts = explode(' as ', $key);
if (count($parts) === 2 && $parts[1] === $alias) {
return true;
}
}
return false;
}

/**
* @param string $use
* @return TraitUsageGenerator
Expand Down
44 changes: 44 additions & 0 deletions test/Generator/ClassGeneratorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -1228,6 +1228,50 @@ public function testCorrectExtendNamesFromGlobalNamespace()
self::assertContains('class ClassName extends DateTime', $classGenerator->generate());
}

public function testCorrectlyExtendsProvidedAliasIfUseAliasExists()
{
$classGenerator = new ClassGenerator();
$classGenerator->setName('ClassName');
$classGenerator->setNamespaceName('SomeNamespace');
$classGenerator->addUse('Foo\\Bar', 'BarAlias');
$classGenerator->setExtendedClass('BarAlias');
$generated = $classGenerator->generate();
self::assertContains('class ClassName extends BarAlias', $generated);
}

public function testCorrectlyExtendsProvidedNamespaceAliasIfUseAliasExistsForNamespace()
{
$classGenerator = new ClassGenerator();
$classGenerator->setName('ClassName');
$classGenerator->setNamespaceName('SomeNamespace');
$classGenerator->addUse('Foo\\Bar', 'BarAlias');
$classGenerator->setExtendedClass('BarAlias\\FooBar');
$generated = $classGenerator->generate();
self::assertContains('class ClassName extends BarAlias\\FooBar', $generated);
}

public function testCorrectlyExtendsAliasOfProvidedFQCNIfUseAliasExists()
{
$classGenerator = new ClassGenerator();
$classGenerator->setName('ClassName');
$classGenerator->setNamespaceName('SomeNamespace');
$classGenerator->addUse('Foo\\Bar', 'BarAlias');
$classGenerator->setExtendedClass('Foo\\Bar');
$generated = $classGenerator->generate();
self::assertContains('class ClassName extends BarAlias', $generated);
}

public function testCorrectlyExtendsWithNamespaceAliasOfProvidedFQCNIfUseAliasExistsForNamespace()
{
$classGenerator = new ClassGenerator();
$classGenerator->setName('ClassName');
$classGenerator->setNamespaceName('SomeNamespace');
$classGenerator->addUse('Foo\\Bar', 'BarAlias');
$classGenerator->setExtendedClass('Foo\\Bar\\FooBar');
$generated = $classGenerator->generate();
self::assertContains('class ClassName extends BarAlias\\FooBar', $generated);
}

public function testCorrectImplementNames()
{
$classGenerator = new ClassGenerator();
Expand Down