Skip to content

Conversation

@Vico1993
Copy link
Contributor

Description

This PR adds support for fetching Zendesk views through the API service. It introduces new service methods to get all views and active views, with support for filtering and pagination options. The Zendesk view model is defined with detailed typings to represent the view structure. Corresponding tests for getViews and getActiveViews are added to ensure correct fetching behavior.

How to manually test

  1. Run the test suite to verify new tests in __tests__/services/zendesk-api-service.spec.ts pass.
  2. Consume the getViews() and getActiveViews() methods from the ZendeskApiService in your code.
  3. Confirm that the methods correctly fetch and return Zendesk views including handling of optional query parameters like access, group_id, and sorting.
  4. Optionally verify the returned data structures conform to the newly added TypeScript interfaces.

Include label

  • Version: Minor

Acceptation criteria

  • Added the corrected label to my pull request
  • Added/updated tests impacted by the change
  • Documentation is up-to-date (README.md / INSTALL.md)
  • Manually tested?

@Vico1993 Vico1993 self-assigned this Nov 25, 2025
github-actions[bot]
github-actions bot previously approved these changes Nov 25, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

@Vico1993 Vico1993 marked this pull request as ready for review November 25, 2025 10:16
@github-actions github-actions bot dismissed their stale review November 25, 2025 10:50

Dismiss bot.

@github-actions github-actions bot added size: L and removed size: M labels Nov 25, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🤖 🚀 🔥

Copy link
Contributor

@pol-mampey pol-mampey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a question, why is this change a minor rather than a patch?

@Vico1993
Copy link
Contributor Author

Looks good! Just a question, why is this change a minor rather than a patch?

Because i'm adding new functionality inside the toolbox

@Vico1993 Vico1993 added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit bf7a4ff Nov 27, 2025
7 checks passed
@Vico1993 Vico1993 deleted the victor.piolin/views branch November 27, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants