-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Implement zendesk views in toolbox #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤖 🚀 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤖 🚀 🔥
pol-mampey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a question, why is this change a minor rather than a patch?
Because i'm adding new functionality inside the toolbox |
Description
This PR adds support for fetching Zendesk views through the API service. It introduces new service methods to get all views and active views, with support for filtering and pagination options. The Zendesk view model is defined with detailed typings to represent the view structure. Corresponding tests for
getViewsandgetActiveViewsare added to ensure correct fetching behavior.How to manually test
__tests__/services/zendesk-api-service.spec.tspass.getViews()andgetActiveViews()methods from theZendeskApiServicein your code.Include label
Acceptation criteria