create function to create basic auth connections for ZIS #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan-vu
requested review from
a team,
Vico1993 and
pol-mampey
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Vico1993
previously approved these changes
Oct 14, 2025
Contributor
Vico1993
left a comment
Vico1993
left a comment
There was a problem hiding this comment.
Looks good! but maybe we could rename createZisConnection ? To avoid confusion between Bearer token and Basic auth?
cuneytcelebican
previously approved these changes
Oct 14, 2025
tristan-vu
force-pushed
the
create-basic-auth-connection
branch
from
d07e0bd to
2ffeee6
Compare
github-actions
bot
dismissed stale reviews from Vico1993, cuneytcelebican, and themself
Dismiss bot.
tristan-vu
force-pushed
the
create-basic-auth-connection
branch
from
0efdb4d to
9a8bc0a
Compare
Vico1993
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for creating ZIS (Zendesk Integration Services) Basic Auth connections through the API. The main changes include introducing a new interface to model the Basic Auth connection response and implementing a new method in the
ZendeskApiServiceto create such connections.ZIS Basic Auth Connection Support:
ICreateZisBasicAuthConnectioninzendesk-integration-services.tsto represent the structure of a Basic Auth connection response.zendesk-api-service.tsfor use in the service layer.createZisBasicAuthConnectioninZendeskApiServiceto allow creating Basic Auth connections for a specified integration, including parameters for username, password, connection name, and allowed domain.How to manually test
⛔
Include label
We are following this pattern to keep our package version updated. Please add the appropriate label to your Pull requests between the following:
Acceptation criteria