`recursive_on_duplicate_key_update` and unique validations

[kalsan]

Hey there and thank you for this awesome gem!

I'm currently using it to import a compount key in the following form where Customer has_many :subscriptions:

import_result = Customer.import(
        customers,
        # validate_uniqueness: false, # TODO: why does this not help?
        validate: false, # TODO: why is this needed?
        recursive:                         true,
        on_duplicate_key_update:           {
          conflict_target: %i[imported_by_id imported_id],
          columns:         %i[
            foo
            bar
          ]
        },
        recursive_on_duplicate_key_update: {
          subscriptions: {
            # validate_uniqueness: false, # TODO: why does this not help?
            conflict_target: %i[imported_by_id imported_id],
            columns:         %i[
              morefoo
              morebar
            ]
          }
        }
      )

As you can see in the "TODO" marked parts above, I need to pass validate: false for the record to sucessfully import. Otherwise, the following validation in Subscription fails:

validates :imported_id, uniqueness: { scope: :imported_by_id }, allow_blank: true

I'm wondering whether this is a problem of understanding on my side or a bug.

Thanks a lot in advance!

Best,
Kalsan

[kaliara]

@kalsan did you happen to make any progress on this? Dealing with the same issue.

[jkowens]

@kalsan and @kaliara Rails 7.2 validation issues should be resolved now in the master branch. Would you be able to point to that branch and test to make sure it is good?

[kaliara]

That fixed it @jkowens, thank you very much!

[jkowens]

That's great news. Just released fix in v1.8.0 🎉

[kalsan]

Hi @jkowens and thanks a lot for the update! Unfortunately, this does not help in my case (even with validate_uniqueness: false in both the parent and child import config.
I guess this is a different problem from what @kaliara is experiencing, as I am still on Rails 7.1.

[jkowens]

@kaliara thanks for following up. I'm wondering if the issue is due to the scoped uniqueness validation, will need to investigate.

[kalsan]

Let me know if I can provide any further information :-)

[jkowens]

@kalsan I'm curious, does the Customer and Subscription import work with validations if you don't do a recursive import?

[kalsan]

@jkowens good point. It does not. The used code:

import_result = Customer.import(
        customers,
        on_duplicate_key_update:           {
          conflict_target: %i[imported_by_id imported_id],
          columns:         %i[
            first_name
            last_name
            contact_person
            address_extra
            street_and_number
            zip_code
            town
            country
            birth_date
            bad_payer
            notes
          ]
        }
      )

Experiments:

• works when validate: false
• does not work if just validate_uniqueness: false
• does not work if both statements are omitted.

[jkowens]

@kalsan can you provide a simple application that reproduces this error? I seem to be having trouble doing so.

[kalsan]

@jkowens here you go :-)

fooimport.zip

Steps required:

• Run postgres (easiest method ist to quickly fire up a docker container and bind it to the host network or forward the port)
• bundle
• rails c
• CustomerImport.run
• CustomerImport.run again -> failure

Let me know if I can help with anything :-)

[jkowens]

Thanks @kalsan this was helpful. So I've determined there is an inherit issue with the way validations are handled for activerecord-import. We jump thru hoops to prevent uniqueness validations from running for a model, but we didn't account for the fact that associations are validated for a record as well. We'll have to think this over a bit.