Add with_read_only() convenience method to store #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
github-actions
bot
removed
the
needs release notes
maxrjones
commented
Jun 18, 2025
dstansby
reviewed
Jun 18, 2025
dstansby
approved these changes
Jun 19, 2025
|
@meeseeksdev backport to 3.0.9 |
meeseeksmachine
pushed a commit
to meeseeksmachine/zarr-python
that referenced
this pull request
Jun 30, 2025
d-v-b
pushed a commit
that referenced
this pull request
Jun 30, 2025
…3181) Co-authored-by: Max Jones <[email protected]>
Closed
3 tasks
d-v-b
added a commit
that referenced
this pull request
Jul 9, 2025
* Enable tests on 3.0.x branch (#3135) * Changelog for 3.0.9 * Backport PR #3149: Add GroupNotFound error to API docs (#3179) Co-authored-by: David Stansby <[email protected]> * Backport PR #3140: Suppress FileNotFoundError when deleting keys in the obstore adapter (#3180) Co-authored-by: Lukas Bindreiter <[email protected]> * Backport PR #3138: Add with_read_only() convenience method to store (#3181) Co-authored-by: Max Jones <[email protected]> * Create read only copy if needed when opening a store path (#3156) * Create read only copy if needed when opening a store path * Add ValueError to Raises section * Update expected warning * Update src/zarr/storage/_common.py Co-authored-by: Davis Bennett <[email protected]> * Use ANY_ACCESS_MODE * Update src/zarr/storage/_common.py Co-authored-by: David Stansby <[email protected]> * Update src/zarr/storage/_common.py Co-authored-by: David Stansby <[email protected]> * Update changes * Try using get_args on definition * Revert "Try using get_args on definition" This reverts commit 7ad760f. * Add test * Remove warning * Apply suggestion for try; except shortening Co-authored-by: Tom Nicholas <[email protected]> * Improve code coverage --------- Co-authored-by: Davis Bennett <[email protected]> Co-authored-by: David Stansby <[email protected]> Co-authored-by: Tom Nicholas <[email protected]> (cherry picked from commit 5731c6c) * Create read only copy if needed when opening a store path (#3156) (#3182) * Create read only copy if needed when opening a store path * Add ValueError to Raises section * Update expected warning * Update src/zarr/storage/_common.py * Use ANY_ACCESS_MODE * Update src/zarr/storage/_common.py * Update src/zarr/storage/_common.py * Update changes * Try using get_args on definition * Revert "Try using get_args on definition" This reverts commit 7ad760f. * Add test * Remove warning * Apply suggestion for try; except shortening * Improve code coverage --------- (cherry picked from commit 5731c6c) Co-authored-by: Max Jones <[email protected]> Co-authored-by: David Stansby <[email protected]> Co-authored-by: Tom Nicholas <[email protected]> * Remove breaking check about `auto_mkdir` for FSSpecStore (#3193) * Remove breaking check from _make_async * Update expected error * Change import structure to protect against AttributeError * changelog * add test to ensure that we can create a read-only copy of the store with auto_mkdir=False * only test if the async wrapper is available --------- Co-authored-by: Davis Bennett <[email protected]> (cherry picked from commit 5a24487) * Remove breaking check about `auto_mkdir` for FSSpecStore (#3193) (#3203) * Remove breaking check from _make_async * Update expected error * Change import structure to protect against AttributeError * changelog * add test to ensure that we can create a read-only copy of the store with auto_mkdir=False * only test if the async wrapper is available --------- (cherry picked from commit 5a24487) Co-authored-by: Max Jones <[email protected]> * Add missing import for AsyncFileSystemWrapper for `_make_async` in `_fsspec.py` (#3195) * Add missing import for AsyncFileSystemWrapper in `_fsspec.py` * Add missing changelog entry for AsyncFileSystemWrapper import fix * Move AsyncFileSystemWrapper import past the version check in `_fsspec.py` * Add newline after AsyncFileSystemWrapper import in `_fsspec.py` * Simplify import statement for AsyncFileSystemWrapper in `_fsspec.py` --------- Co-authored-by: Altay Sansal <[email protected]> (cherry picked from commit 97aa42f) * Auto backport of pr 3195 on 3.0.10 (#3204) * Remove breaking check about `auto_mkdir` for FSSpecStore (#3193) * Remove breaking check from _make_async * Update expected error * Change import structure to protect against AttributeError * changelog * add test to ensure that we can create a read-only copy of the store with auto_mkdir=False * only test if the async wrapper is available --------- Co-authored-by: Davis Bennett <[email protected]> (cherry picked from commit 5a24487) * Add missing import for AsyncFileSystemWrapper for `_make_async` in `_fsspec.py` (#3195) * Add missing import for AsyncFileSystemWrapper in `_fsspec.py` * Add missing changelog entry for AsyncFileSystemWrapper import fix * Move AsyncFileSystemWrapper import past the version check in `_fsspec.py` * Add newline after AsyncFileSystemWrapper import in `_fsspec.py` * Simplify import statement for AsyncFileSystemWrapper in `_fsspec.py` --------- Co-authored-by: Altay Sansal <[email protected]> (cherry picked from commit 97aa42f) --------- Co-authored-by: Max Jones <[email protected]> Co-authored-by: Altay Sansal <[email protected]> Co-authored-by: Altay Sansal <[email protected]> * 3.0.9 release notes (#3183) * Create read only copy if needed when opening a store path (#3156) * Create read only copy if needed when opening a store path * Add ValueError to Raises section * Update expected warning * Update src/zarr/storage/_common.py Co-authored-by: Davis Bennett <[email protected]> * Use ANY_ACCESS_MODE * Update src/zarr/storage/_common.py Co-authored-by: David Stansby <[email protected]> * Update src/zarr/storage/_common.py Co-authored-by: David Stansby <[email protected]> * Update changes * Try using get_args on definition * Revert "Try using get_args on definition" This reverts commit 7ad760f. * Add test * Remove warning * Apply suggestion for try; except shortening Co-authored-by: Tom Nicholas <[email protected]> * Improve code coverage --------- Co-authored-by: Davis Bennett <[email protected]> Co-authored-by: David Stansby <[email protected]> Co-authored-by: Tom Nicholas <[email protected]> (cherry picked from commit 5731c6c) * release notes --------- Co-authored-by: Max Jones <[email protected]> Co-authored-by: David Stansby <[email protected]> Co-authored-by: Tom Nicholas <[email protected]> * release notes --------- Co-authored-by: Lumberbot (aka Jack) <[email protected]> Co-authored-by: Lukas Bindreiter <[email protected]> Co-authored-by: Max Jones <[email protected]> Co-authored-by: Davis Bennett <[email protected]> Co-authored-by: Tom Nicholas <[email protected]> Co-authored-by: Altay Sansal <[email protected]> Co-authored-by: Altay Sansal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Store.with_read_only()convenience method to create a new store with a different read mode. By default, the method raises aNotImplementedError. The motivation is to make it simpler for downstream libraries to adapt to the changes in #3068. For example, this would make it much simpler to address the 269 failures in Xarray's upstream test suite and the failures in VirtualiZarr's upstream test suite.This is similar to the functionality added in #2249 and removed in #2442. @jhamman would you be able to offer any details on the motivation for previously removing the similar functionality?
TODO:
docs/user-guide/*.rstchanges/