-
-
Notifications
You must be signed in to change notification settings - Fork 356
Fix for empty consolidated metadata dataset: backwards compatibility w/ 2.x #2695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
we should add a case in our consolidated metadata tests for this, happy to provide guidance there if needed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2695 +/- ##
==========================================
- Coverage 99.98% 90.29% -9.70%
==========================================
Files 38 59 +21
Lines 14718 6468 -8250
==========================================
- Hits 14716 5840 -8876
- Misses 2 628 +626
|
I just added a simple tests that is able trigger this issue (before the fix) but I'm not so familiar with the code base to know if this is the best place and way to check for this |
Co-authored-by: Davis Bennett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I just cleaned up the release note a little bit.
This is a quick fix for the problem reported in #2694 where an empty consolidated dataset created with
zarr-python 2.x
fails to being read byzarr-python 3.x
because of the absence of.zattrs
from the store.New/modified features documented in docs/tutorial.rst