Add docs requirements to pyproject.toml
#1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs release notes
|
Toggling for RTD. Looks like the last build was unable to fetch the PR |
|
Weird RTD still can't fetch the PR |
|
Maybe this is upstream issue ( readthedocs/readthedocs.org#10601 ). Not sure why it started happening just now. Numcodecs didn't have the same issue. Also builds on |
|
Well at least RTD is reporting the status now, which it wasn't before. Let's see what upstream says |
github-actions
bot
removed
the
needs release notes
Move the RTD exclusion to the `numpy` dependency directly.
jakirkham
commented
Aug 9, 2023
| @@ -13,7 +13,7 @@ maintainers = [ | |||
| requires-python = ">=3.8" | |||
| dependencies = [ | |||
| 'asciitree', | |||
| 'numpy>=1.20', | |||
| 'numpy>=1.20,!=1.21.0', | |||
There was a problem hiding this comment.
xref: numpy/numpy#19325
jakirkham
force-pushed
the
use_pyproj_rtd
branch
from
4e58e22 to
1d13385
Compare
jakirkham
commented
Aug 9, 2023
| 'sphinx-rtd-theme', | ||
| 'pydata-sphinx-theme', | ||
| 'numpydoc', | ||
| 'numcodecs[msgpack]', |
There was a problem hiding this comment.
Since msgpack is a numcodecs requirement, specify it via numcodecs' extra requirement
|
@joshmoore could you please review? This is some follow on work from issue ( #1492 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a separate requirements file for RTD, fold these requirements into
pyproject.tomlas is done with Numcodecs.