Move Parser definition to new parser.typing module #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomNicholas
had a problem deploying
to
test-release
GitHub Actions
Failure
7 tasks
maxrjones
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The targeted PR that #619 should have been. All this does is move where
Parseris defined tovirtualizarr.parsers.typing. This PR doesn't touch any docs, so shouldn't conflict with #615. #619 should be merged after this one.Parserprotocol toparsers.typing#616Tests addedChanges are documented in(will be done in Docs and API follow-ups to #601 #619)docs/releases.rstNew functions/methods are listed in(will be done in Docs and API follow-ups to #601 #619)api.rstNew functionality has documentation(will be done in Docs and API follow-ups to #601 #619)