Optionally leave out patch version and only use major.minor - #29
Closed
levsa wants to merge 1 commit into
Closed
Conversation
heisluft
added a commit
to AntiLaby/jsemver
that referenced
this pull request
Jan 31, 2019
implemented some prs (zafarkhaja#31, zafarkhaja#29)
zafarkhaja
self-requested a review
April 13, 2023 04:53
Owner
|
Hello Levon, I hope you're doing well! I'm sorry it took me this long to get back to you. I appreciate you taking the time and effort to contribute. I totally understand the use case and the need for this functionality but unfortunately, as I've said on numerous occasions elsewhere, I'm not willing to deviate from the Specification in the default parser. I still am planning to support this in some future release, but with a separate parser. Have a nice day, |
zafarkhaja
added
status/rejected
and removed
type/invalid
type/enhancement
status/rejected
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be useful if patch version was optional, i.e. versions could be 1.3, 1.3-RC1 etc. I'm using the axion-release-plugin which uses jsemver, and this pull request making patch version optional greatly simplifies configuration of release versions, i.e. serializing/deserializing to take care of adding/removing ".0".