Skip to content

Test Label Trigger#843

Open
oxve wants to merge 3 commits into
mainfrom
reuse-build-artifacts_sandbox
Open

Test Label Trigger#843
oxve wants to merge 3 commits into
mainfrom
reuse-build-artifacts_sandbox

Conversation

@oxve

@oxve oxve commented Apr 17, 2026

Copy link
Copy Markdown
Member

Testing label trigger and artifact reuse.

@oxve oxve added the runtest label Apr 17, 2026
@github-actions github-actions Bot removed the runtest label Apr 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


ci: Update workflow dispatcher expensive list

Update the list of expensive GitHub Actions workflows to include
Linux and tvOS platforms. This ensures that these platform builds
are correctly subjected to label-based triggering mechanisms
within the CI pipeline.

Also, correct a missing trailing slash in the artifact path for
the print_logs action, improving robustness for artifact reuse.

Bug: 843

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a syntax error in the print_logs action by adding a missing closing quote to a file path. A review comment identifies a potential logic issue where the source GCS path lacks the matrix configuration variable present in the destination path, which could cause the copy command to fail.

run: |
gcloud storage cp "gs://${{ steps.gcs-project.outputs.name }}-test-artifacts/${WORKFLOW}/${GITHUB_RUN_NUMBER}/${{matrix.platform}}/symbols/*" \
"${GITHUB_WORKSPACE}/out/${{ matrix.platform }}_${{ matrix.config }}/lib.unstripped/
"${GITHUB_WORKSPACE}/out/${{ matrix.platform }}_${{ matrix.config }}/lib.unstripped/"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The destination path includes ${{ matrix.config }}, but the source GCS path on line 32 only uses ${{matrix.platform}}. This inconsistency will likely cause the command to fail if the artifacts in the GCS bucket are organized by both platform and configuration, which is the standard practice for build symbols.

@oxve
oxve requested review from a team as code owners April 17, 2026 06:54
@oxve
oxve requested review from briantting and removed request for a team April 17, 2026 06:54
@copybara-service
copybara-service Bot force-pushed the main branch 2 times, most recently from 6367de0 to 239d465 Compare April 23, 2026 11:19
@oxve
oxve removed request for a team June 11, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant