Prune fenced frame and Private state tokens#11509
Conversation
🤖 Gemini Suggested Commit Message💡 Pro Tips for a Better Commit Message:
|
There was a problem hiding this comment.
Code Review
This pull request adds fenced frame sources to the browser build configuration and conditionally gates the trust tokens dependency in the network service under the enable_privacy_sandbox_apis flag. However, gating the dependency without also conditionally gating the corresponding source files that use trust tokens will lead to compilation or linker errors when the flag is disabled. Additionally, ensure that the enable_privacy_sandbox_apis build variable is properly imported in services/network/BUILD.gn to prevent GN build failures.
| if (enable_privacy_sandbox_apis) { | ||
| deps += [ "//services/network/trust_tokens" ] | ||
| } |
There was a problem hiding this comment.
Gating //services/network/trust_tokens in deps without conditionally gating the source files in services/network (e.g., network_context.cc, network_service.cc) that depend on trust tokens will lead to compilation or linker errors when enable_privacy_sandbox_apis is false. The corresponding source files and preprocessor guards must be updated to handle the conditional exclusion of trust_tokens.
References
- Surgical Feature Gating guidelines require following the guidelines and checking the PR audit checklist in Surgical Feature Gating Rules when gating features or targets to optimize binary size. (link)
| if (enable_privacy_sandbox_apis) { | ||
| deps += [ "//services/network/trust_tokens" ] | ||
| } |
There was a problem hiding this comment.
If enable_privacy_sandbox_apis is not imported in this file, the GN build will fail with an 'unknown variable' error. Add the appropriate import statement (e.g., import("//cobalt/build/config/features.gni") or the relevant .gni file) at the top of services/network/BUILD.gn if it is not already present.
References
- Surgical Feature Gating guidelines require following the guidelines and checking the PR audit checklist in Surgical Feature Gating Rules when gating features or targets to optimize binary size. (link)
Bug: 505811196