Update package versions and build scripts #143
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe recent updates enhance the build and deployment processes across multiple projects in the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant CI
participant Storybook
participant Components
Developer->>CI: Trigger build
CI->>Storybook: Execute pnpm run build
Storybook->>Components: Build components
Components-->>Storybook: Components ready
Storybook-->>CI: Build complete
CI-->>Developer: Notify build success
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
hackerwins
force-pushed
the
revise-packages
branch
from
fd168c2 to
7880315
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- .github/workflows/ci.yml (1 hunks)
- .github/workflows/storybook-publish.yml (1 hunks)
- apps/storybook/package.json (1 hunks)
- apps/web/package.json (1 hunks)
- package.json (1 hunks)
- packages/components/package.json (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/storybook-publish.yml
Additional comments not posted (15)
package.json (4)
3-3: Verify the version increment.The version number has been updated from
0.0.1to0.5.33. Ensure that this increment aligns with the project's versioning strategy and accurately reflects the extent of changes made.
7-7: Ensure the build script works as intended.The
buildscript has been added:"build": "pnpm -r run build". Verify that this script correctly initiates the build process for all relevant packages.
8-8: Ensure the dev script works as intended.The
devscript has been added:"dev": "pnpm -r run dev". Verify that this script correctly initiates the development process for all relevant packages.
9-9: Ensure the version script works as intended.The
versionscript has been added:"version": "pnpm -r exec -- npm version $npm_package_version". Verify that this script correctly updates the package version dynamically..github/workflows/ci.yml (1)
22-22: Verify the build command change.The build command has been changed from
pnpm itopnpm run build. Ensure that this new command correctly initiates the build process and generates the necessary build artifacts.apps/web/package.json (3)
2-2: Verify the package name change.The package name has been changed from
@yorkie-ui/testto@yorkie-ui/web. Ensure that the new package name accurately reflects the package's purpose and aligns with the project's naming conventions.
3-3: Verify the version increment.The version number has been updated from
0.0.1to0.5.33. Ensure that this increment aligns with the project's versioning strategy and accurately reflects the extent of changes made.
6-6: Ensure the prebuild script works as intended.The
prebuildscript has been added:"prebuild": "pnpm --filter @yorkie-ui/components build". Verify that this script correctly builds the@yorkie-ui/componentspackage prior to the main build process.apps/storybook/package.json (4)
4-4: Verify adherence to semantic versioning.The version number has been incremented significantly. Ensure that this change follows semantic versioning guidelines, indicating new features, fixes, or breaking changes as appropriate.
7-7: Verify the correctness of theprebuildscript.The
prestorybookscript has been replaced withprebuild. Ensure that this new script is correctly defined and used within the project.
8-8: Verify the functionality of the new build command.The
buildscript has been simplified to directly executestorybook build. Ensure that this new command works as expected and does not break the build process.
10-10: Verify the functionality of the new development command.The
devscript has been introduced to streamline the development workflow. Ensure that this new command works as expected and enhances the development process.packages/components/package.json (3)
3-3: Verify adherence to semantic versioning.The version number has been incremented significantly. Ensure that this change follows semantic versioning guidelines, indicating new features, fixes, or breaking changes as appropriate.
26-26: Verify the correctness of thebuild:stylescript.The
build:stylescript has been redefined to enhance the build process by generating CSS styles. Ensure that this new script is correctly defined and used within the project.
28-28: Verify the functionality of thepreparescript.The
preparescript has been retained to ensure the code generation process. Ensure that this script works as expected and does not break the build process.
What this PR does / why we need it:
Update package versions and build scripts
Special notes for your reviewer:
Which issue(s) this PR fixes:
Fixes #
Checklist:
Summary by CodeRabbit
New Features
Bug Fixes
Chores