Skip to content

Inconsistent clone() requirement when passing Classes to HTML elements vs. components (#3589) #3931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WorldSEnder merged 5 commits into from
Oct 22, 2025
Merged

Inconsistent clone() requirement when passing Classes to HTML elements vs. components (#3589) #3931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a153a69
Add From<&Classes> impl to allow &Classes in element props (#3589)
sshekhar563 Oct 11, 2025
5cfa101
Update classes.rs
sshekhar563 Oct 11, 2025
b6ffd91
Merge remote-tracking branch 'upstream/master' into implicit-clone-cl…
WorldSEnder Oct 22, 2025
884b36b
bless error output
WorldSEnder Oct 22, 2025
02efc44
bless more impl error messages
WorldSEnder Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/yew-macro/tests/classes_macro/classes-fail.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,14 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
| ^^ the trait `From<{integer}>` is not implemented for `Classes`
|
= help: the following other types implement trait `From<T>`:
`Classes` implements `From<&Classes>`
`Classes` implements `From<&Option<T>>`
`Classes` implements `From<&String>`
`Classes` implements `From<&[T]>`
`Classes` implements `From<&implicit_clone::unsync::string::IString>`
`Classes` implements `From<&str>`
`Classes` implements `From<Cow<'_, str>>`
`Classes` implements `From<Option<T>>`
`Classes` implements `From<String>`
and $N others
= note: required for `{integer}` to implement `Into<Classes>`
note: required by a bound in `Classes::push`
Expand All @@ -40,14 +40,14 @@ error[E0277]: the trait bound `Classes: From<{float}>` is not satisfied
| ^^^^ the trait `From<{float}>` is not implemented for `Classes`
|
= help: the following other types implement trait `From<T>`:
`Classes` implements `From<&Classes>`
`Classes` implements `From<&Option<T>>`
`Classes` implements `From<&String>`
`Classes` implements `From<&[T]>`
`Classes` implements `From<&implicit_clone::unsync::string::IString>`
`Classes` implements `From<&str>`
`Classes` implements `From<Cow<'_, str>>`
`Classes` implements `From<Option<T>>`
`Classes` implements `From<String>`
and $N others
= note: required for `{float}` to implement `Into<Classes>`
note: required by a bound in `Classes::push`
Expand All @@ -66,14 +66,14 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
| required by a bound introduced by this call
|
= help: the following other types implement trait `From<T>`:
`Classes` implements `From<&Classes>`
`Classes` implements `From<&Option<T>>`
`Classes` implements `From<&String>`
`Classes` implements `From<&[T]>`
`Classes` implements `From<&implicit_clone::unsync::string::IString>`
`Classes` implements `From<&str>`
`Classes` implements `From<Cow<'_, str>>`
`Classes` implements `From<Option<T>>`
`Classes` implements `From<String>`
and $N others
= note: required for `{integer}` to implement `Into<Classes>`
= note: required for `Classes` to implement `From<Vec<{integer}>>`
Expand All @@ -92,14 +92,14 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
| ^^^^ the trait `From<{integer}>` is not implemented for `Classes`
|
= help: the following other types implement trait `From<T>`:
`Classes` implements `From<&Classes>`
`Classes` implements `From<&Option<T>>`
`Classes` implements `From<&String>`
`Classes` implements `From<&[T]>`
`Classes` implements `From<&implicit_clone::unsync::string::IString>`
`Classes` implements `From<&str>`
`Classes` implements `From<Cow<'_, str>>`
`Classes` implements `From<Option<T>>`
`Classes` implements `From<String>`
and $N others
= note: required for `{integer}` to implement `Into<Classes>`
= note: required for `Classes` to implement `From<Option<{integer}>>`
Expand All @@ -118,14 +118,14 @@ error[E0277]: the trait bound `Classes: From<u32>` is not satisfied
| ^^^^ the trait `From<u32>` is not implemented for `Classes`
|
= help: the following other types implement trait `From<T>`:
`Classes` implements `From<&Classes>`
`Classes` implements `From<&Option<T>>`
`Classes` implements `From<&String>`
`Classes` implements `From<&[T]>`
`Classes` implements `From<&implicit_clone::unsync::string::IString>`
`Classes` implements `From<&str>`
`Classes` implements `From<Cow<'_, str>>`
`Classes` implements `From<Option<T>>`
`Classes` implements `From<String>`
and $N others
= note: required for `u32` to implement `Into<Classes>`
= note: required for `Classes` to implement `From<Option<u32>>`
Expand All @@ -144,14 +144,14 @@ error[E0277]: the trait bound `Classes: From<{integer}>` is not satisfied
| ^^ the trait `From<{integer}>` is not implemented for `Classes`
|
= help: the following other types implement trait `From<T>`:
`Classes` implements `From<&Classes>`
`Classes` implements `From<&Option<T>>`
`Classes` implements `From<&String>`
`Classes` implements `From<&[T]>`
`Classes` implements `From<&implicit_clone::unsync::string::IString>`
`Classes` implements `From<&str>`
`Classes` implements `From<Cow<'_, str>>`
`Classes` implements `From<Option<T>>`
`Classes` implements `From<String>`
and $N others
= note: required for `{integer}` to implement `Into<Classes>`
note: required by a bound in `Classes::push`
Expand Down
1 change: 1 addition & 0 deletions packages/yew-macro/tests/html_macro/element-fail.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ error[E0277]: the trait bound `implicit_clone::unsync::string::IString: From<{in
| ^^ the trait `From<{integer}>` is not implemented for `implicit_clone::unsync::string::IString`
|
= help: the following other types implement trait `From<T>`:
`implicit_clone::unsync::string::IString` implements `From<&Classes>`
`implicit_clone::unsync::string::IString` implements `From<&implicit_clone::unsync::string::IString>`
`implicit_clone::unsync::string::IString` implements `From<&str>`
`implicit_clone::unsync::string::IString` implements `From<Arguments<'_>>`
Expand Down
12 changes: 12 additions & 0 deletions packages/yew/src/html/classes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,18 @@ impl<T: Into<Classes>, const SIZE: usize> From<[T; SIZE]> for Classes {
}
}

impl From<&Classes> for Classes {
fn from(c: &Classes) -> Self {
c.clone()
}
}

impl From<&Classes> for AttrValue {
fn from(c: &Classes) -> Self {
c.clone().into_prop_value()
}
}

impl PartialEq for Classes {
fn eq(&self, other: &Self) -> bool {
self.set.len() == other.set.len() && self.set.iter().eq(other.set.iter())
Expand Down
Loading