-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix internally tracked sibling positions earlier when hydrating #3914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
previously, the fixup was done in the first "real" render, now this happens immediately in the render that transitions from ComponentRenderState::Hydration to ComponentRenderState::Render. We do so by threading through a reference to the sibling that needs a fix
|
Visit the preview URL for this PR (updated for commit de85d40): https://yew-rs-api--pr3914-fix-early-rerender-daywzpi8.web.app (expires Tue, 16 Sep 2025 10:11:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
|
Small explanation why the previous approach was not always correctly working: |
Previously, the fixup of
next_siblings was done in the first "priority" render, now this happens immediately in the render that transitions from ComponentRenderState::Hydration to ComponentRenderState::Render.We do so by threading through a reference to the sibling that needs a fix
Fixes #3913
Checklist