bump MSRV to 1.84.0 and use resolver 3#3900
Merged
Madoshakalaka merged 3 commits intomasterfrom Aug 20, 2025
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 581e143): https://yew-rs--pr3900-bump-msrv-1-84-resol-gksj7dsb.web.app (expires Mon, 25 Aug 2025 19:47:45 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Madoshakalaka
commented
Aug 14, 2025
Member
Author
There was a problem hiding this comment.
this looks like a regression, I'll check
Benchmark - coreYew MasterPull Request |
Madoshakalaka
commented
Aug 14, 2025
Member
Author
There was a problem hiding this comment.
This looks like a regression
Madoshakalaka
commented
Aug 14, 2025
Comment on lines
-580
to
+592
| = help: the trait `HasProp<int, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildPropertiesBuilder, _>` | ||
| = help: the trait `HasProp<int, _>` is not implemented for `AssertAllProps` | ||
| = help: the following other types implement trait `HasProp<P, How>`: | ||
| `CheckChildContainerPropertiesAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckChildPropertiesAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckChildrenPropsAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckContextProviderPropsAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckHtmlInPropsPropertiesAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `HasChildContainerPropertieschildren<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `HasChildContainerPropertieschildren<B>` implements `HasProp<_ChildContainerProperties::children, HasChildContainerPropertieschildren<B>>` | ||
| `HasChildPropertiesint<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| and $N others |
Member
Author
There was a problem hiding this comment.
this too is no good
Madoshakalaka
commented
Aug 14, 2025
Comment on lines
-630
to
+652
| = help: the trait `HasProp<_ChildContainerProperties::children, _>` is not implemented for `AssertAllProps`, which is required by `AssertAllProps: AllPropsFor<ChildContainerPropertiesBuilder, _>` | ||
| = help: the trait `HasProp<_ChildContainerProperties::children, _>` is not implemented for `AssertAllProps` | ||
| = help: the following other types implement trait `HasProp<P, How>`: | ||
| `CheckChildContainerPropertiesAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckChildPropertiesAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckChildrenPropsAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckContextProviderPropsAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `CheckHtmlInPropsPropertiesAll<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `HasChildContainerPropertieschildren<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| `HasChildContainerPropertieschildren<B>` implements `HasProp<_ChildContainerProperties::children, HasChildContainerPropertieschildren<B>>` | ||
| `HasChildPropertiesint<B>` implements `HasProp<P, &dyn HasProp<P, How>>` | ||
| and $N others |
Madoshakalaka
commented
Aug 14, 2025
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Member
Author
|
I determined the suddenly verbose type suggestions shouldn't be worried about. As a context, the old diagnostics were generated by 1.78 compiler and the new ones 1.84, neither of which should pick up the I think 1.84 has gotten "better" at suggestions (worse for us). The verbosity will go away for any yew users on 1.85+ anyways. With the MSRV raised, this diagnostics regression will only affect the unmeasurable set of yew users on 1.84 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
Seems all fine! Imma merg' it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolver 3 is rust version aware and this will stop dependabot from suggesting us with crates with rust version requirements that are too high. 1.84 is the minimum rust version to opt-in resolver 3. When we later upgrade to edition 2024, resolver 3 will be the default.
Major changes
Documentation Updates