Skip to content

Apply attributes before inserting elements into the DOM #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WorldSEnder merged 1 commit into from
Aug 12, 2025
Merged

Apply attributes before inserting elements into the DOM #3892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/yew/src/dom_bundle/btag/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,16 @@ impl Reconcilable for VTag {
key,
..
} = self;
slot.insert(parent, &el);

// Apply attributes BEFORE inserting the element into the DOM
// This is crucial for SVG animation elements where the animation
// starts immediately upon DOM insertion
let attributes = attributes.apply(root, &el);
let listeners = listeners.apply(root, &el);

// Now insert the element with attributes already set
slot.insert(parent, &el);

let inner = match self.inner {
VTagInner::Input(f) => {
let f = f.apply(root, el.unchecked_ref());
Expand Down
Loading