website: make tutorial testable #3879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 808679e): https://yew-rs--pr3879-make-tutorial-testab-3dwlox6t.web.app (expires Sat, 26 Jul 2025 09:40:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
its-the-shrimp
force-pushed
the
make-tutorial-testable
branch
2 times, most recently
from
3992686 to
d4c6dfb
Compare
Madoshakalaka
requested changes
Jul 19, 2025
Member
|
Just food for thought: we can also generate one test file for each diff block to ensure each intermediate step compiles too. |
its-the-shrimp
force-pushed
the
make-tutorial-testable
branch
from
d4c6dfb to
808679e
Compare
Contributor
Author
If the end result compiles, then it doesn't matter too much whether the individual steps do |
Madoshakalaka
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a test assembler in
tools/website-testenabled by a special flag in a doc file. Its usage is documented in website/README.md. While joining the code blocks, it'll verify the coherence of diff blocks, solving the problem of the tutorial getting "out of touch with reality"Checklist