Skip to content

Conversation

@brilliantkid87
Copy link
Contributor

@brilliantkid87 brilliantkid87 commented Nov 6, 2024

Description

  1. Regex and Version Extraction: Updated useVersion hook with a descriptive regex constant (VERSION_REGEX) to extract the version from the URL.
  2. API URL Handling: Created a helper function, getApiUrl, to dynamically determine the API URL based on the extracted version. This replaces inline logic for API URL generation.
  3. Constants: Moved API base URLs to a centralized constant (API_BASE_URLS) for cleaner and more flexible URL management.
  • I have reviewed my own code
  • I have added tests

@Madoshakalaka
Copy link
Member

This replaces inline logic for API URL generation.

not sure this is necessary. Thanks for the contribution

@Madoshakalaka Madoshakalaka merged commit 3048c75 into yewstack:master Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants