yew-router: Dynamic basename. #3725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnbear
force-pushed
the
dynamic_basename_2
branch
from
0eb58be to
5bcfd0e
Compare
finnbear
changed the title
finnbear
commented
Sep 12, 2024
ranile
reviewed
Sep 19, 2024
ranile
reviewed
Sep 20, 2024
Member
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Thanks for making the change. I have just one more concern here. Other than that, it looks good.
geoffjay
pushed a commit
to geoffjay/yew
that referenced
this pull request
Jan 25, 2025
* yew-router: Dynamic basename. * Revisions. * Test location.path and navigator.basename match expectations at each step. * Better coverage of edge case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
basenamechanges, the URL isn't updated and the oldbasenameis persisted until the next navigation. With this PR,basenamechanges take effect immediately.basenameis initiallySome, the URL may lack thebasenameuntil the next nagvigation. With this PR, thebasenameis immediately added to the URL.Motivation
In my application, base path is used for something resembling a workspace while route is used for something resembling a page id with parameters. The base path may not exist (the default 'workspace') or may change (when moving between 'workspaces').
Checklist
added testsmodified existing test to test all new functionality