Skip to content

if xmlns attribute is specified, use that namespace when creating ele… #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Madoshakalaka merged 4 commits into from
Mar 13, 2025
Merged

if xmlns attribute is specified, use that namespace when creating ele… #3629

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03354ac
if xmlns attribute is specified, use that namespace when creating ele…
Mar 9, 2024
b11877d
Merge branch 'master' of https://github.com/yewstack/yew into vtag-cr…
Madoshakalaka Mar 13, 2025
ee0be5d
formatting and clippy suggestion
Madoshakalaka Mar 13, 2025
a2f1aa6
Merge branch 'master' of https://github.com/yewstack/yew into vtag-cr…
Madoshakalaka Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/yew/src/dom_bundle/btag/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,18 @@ impl Reconcilable for VTag {
impl VTag {
fn create_element(&self, parent: &Element) -> Element {
let tag = self.tag();

if tag == "svg" || parent.namespace_uri().is_some_and(|ns| ns == SVG_NAMESPACE) {
// check for an xmlns attribute. If it exists, create an element with the specified
// namespace
if let Some(xmlns) = self
.attributes
.iter()
.find(|(k, _)| *k == "xmlns")
.map(|(_, v)| v)
{
document()
.create_element_ns(Some(xmlns), tag)
.expect("can't create namespaced element for vtag")
} else if tag == "svg" || parent.namespace_uri().is_some_and(|ns| ns == SVG_NAMESPACE) {
let namespace = Some(SVG_NAMESPACE);
document()
.create_element_ns(namespace, tag)
Expand Down
Loading