Skip to content

use_future_with: simplify code a bit by using read-only use_memo rather than use_state #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ranile merged 3 commits into from
Aug 3, 2024
Merged

use_future_with: simplify code a bit by using read-only use_memo rather than use_state #3610

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8deac09
use_future_with: simplify code a bit by using read-only use_memo rath…
Ekleog Feb 21, 2024
aaa4f98
Merge branch 'master' into simplify-use-future
ranile Aug 3, 2024
a3f3bb5
use use_ref instead of use_memo_base
ranile Aug 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/yew/src/suspense/hooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ where
let output = use_state(|| None);
// We only commit a result if it comes from the latest spawned future. Otherwise, this
// might trigger pointless updates or even override newer state.
let latest_id = use_state(|| Cell::new(0u32));
let latest_id = use_memo_base(|()| (Cell::new(0u32), ()), ());

let suspension = {
let output = output.clone();
Expand Down