You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some examples got impacted by remove ToHtml trait #3453 (the removal of ToHtml), I fixed them so we can use reference where it makes sense (I added a few IntoPropValue on cheap-to-clone types)
Updated implicit-clone to the latest version
Optimized ChildrenRenderer memory allocations by using Rc
Changes did on the side:
In order to get some example working, I had to change NodeSeq to use IArray. This is good because it is more optimized for memory allocations too
Slightly improve the API of VChild to easily get a ref mut inside its properties object (just for convenience!)
@kirillsemyonkin now I think the benchmark results look good. Not a big improvement but not a lost either except maybe on the "baseline" but that's probably normal.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR do?
Changes did on the side:
Related to #3453
Checklist