Allow boolean & update error for byte literals in html!

[its-the-shrimp]

Description

Adds support for the following usage of the html! macro:

html!{<>
  { b'a' }
  { true }
</>}

• I have reviewed my own code
• I have added tests

[github-actions]

Visit the preview URL for this PR (updated for commit 558b30c):

https://yew-rs-api--pr3441-allow-more-literals-ppr0g8os.web.app

_{(expires Sat, 04 Nov 2023 18:38:54 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

[github-actions]

Size Comparison

Details

examples	master (KB)	pull request (KB)	diff (KB)	diff (%)
async_clock	103.070	103.070	0	0.000%
boids	176.629	176.629	0	0.000%
communication_child_to_parent	95.648	95.648	0	0.000%
communication_grandchild_with_grandparent	108.768	108.768	0	0.000%
communication_grandparent_to_grandchild	105.178	105.178	0	0.000%
communication_parent_to_child	93.126	93.126	0	0.000%
contexts	112.460	112.460	0	0.000%
counter	89.818	89.818	0	0.000%
counter_functional	90.479	90.479	0	0.000%
dyn_create_destroy_apps	93.040	93.040	0	0.000%
file_upload	104.083	104.083	0	0.000%
function_memory_game	175.535	175.535	0	0.000%
function_router	351.553	351.553	0	0.000%
function_todomvc	164.044	164.044	0	0.000%
futures	232.037	232.037	0	0.000%
game_of_life	112.904	112.904	0	0.000%
immutable	190.158	190.158	0	0.000%
inner_html	86.141	86.141	0	0.000%
js_callback	113.525	113.525	0	0.000%
keyed_list	202.478	202.478	0	0.000%
mount_point	89.028	89.028	0	0.000%
nested_list	117.085	117.085	0	0.000%
node_refs	96.723	96.723	0	0.000%
password_strength	1753.727	1753.727	0	0.000%
portals	97.796	97.796	0	0.000%
router	320.700	320.700	0	0.000%
simple_ssr	143.755	143.755	0	0.000%
ssr_router	389.493	389.493	0	0.000%
suspense	119.868	119.868	0	0.000%
timer	92.348	92.348	0	0.000%
timer_functional	101.132	101.132	0	0.000%
todomvc	144.134	144.134	0	0.000%
two_apps	89.880	89.880	0	0.000%
web_worker_fib	138.090	138.090	0	0.000%
web_worker_prime	188.784	188.784	0	0.000%
webgl	88.748	88.748	0	0.000%

✅ None of the examples has changed their size significantly.

[github-actions]

Benchmark - SSR

Yew Master

Details

Benchmark	Round	Min (ms)	Max (ms)	Mean (ms)	Standard Deviation
Baseline	10	428.970	457.062	440.000	9.633
Hello World	10	704.175	731.213	714.540	8.832
Function Router	10	2377.232	2459.566	2409.243	22.991
Concurrent Task	10	1008.319	1011.532	1010.472	0.918
Many Providers	10	1627.578	1698.256	1653.789	23.599

Pull Request

Details

Benchmark	Round	Min (ms)	Max (ms)	Mean (ms)	Standard Deviation
Baseline	10	424.808	460.220	438.605	10.296
Hello World	10	704.032	738.847	719.232	12.083
Function Router	10	2393.186	2483.879	2442.656	32.208
Concurrent Task	10	1008.987	1011.855	1010.393	0.910
Many Providers	10	1636.526	1687.289	1667.949	16.303

[ranile]

Since the VDOM API supports it, I don't see why the macro shouldn't. Thanks for the PR!

GH actions should not have approved this

[cecton]

I'm not sure why/how a byte would be useful? A byte is literally a u8, so it's converting b'a' to the string "97"?

[its-the-shrimp]

It would indeed be strange to use a byte literal in HTML, but who knows what use cases are there in the wild, I think it would be even more strange to pretend like it's not stringifiable at compile-time.

[ranile]

That is a valid point. What if we improved the diagnostic instead of just saying "invalid type"?

[its-the-shrimp]

What if we improved the diagnostic instead of just saying "invalid type"?

I did just that for byte-string literals in this PR, the only Rust literal kind that generates a non-Displayable value.

[futursolo]

This is similar to ByteStr, however since a byte is u8 and u8 supports Display.
So I am not sure not allowing b'A' would be effective.

[futursolo]

Thanks! LGTM.

[ranile]

I'm sorry it took me this long to merge this